This repository was archived by the owner on Sep 27, 2023. It is now read-only.
[WIP] Improvements - #186
Draft
dingo-d wants to merge 22 commits into
Draft
Conversation
…ty fixes and visibility fixes on methods
Remove checkbox for PHP only checks as only PHP will be checked by the phpcs. Need to figure out what to do with esprima and JS
Ignored possible race condition in JS code.
This is a big WIP.
Testing skipping some checks for DI preparation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding improvements - a11y improvements, performance improvements (DI container), remove JS checks in PHPCS, webpack config improvements