fix(release): pass secrets to checks job - #133
Merged
Merged
Conversation
The harden-release-workflow PR (#128) dropped 'secrets: inherit' from the checks job in release.yml. The reusable checks workflow uses integration-test secrets like RESEND_API_KEY, so the next release run failed with empty env vars. Re-adding secrets: inherit restores the previous behaviour. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression fix for #128. That PR dropped
secrets: inheritfrom thechecksjob inrelease.yml. Since the reusablechecks.ymluses integration-test secrets (RESEND_API_KEY,AWS_SECRET_ACCESS_KEY, etc.) the release that ran after merging #128 failed with empty env vars. This restores the previoussecrets: inheritline.Re-running the release workflow after merge should pass.
🤖 Generated with Claude Code