Update guacamole-user-sync to v0.8.1 - #2662
Merged
cptanalatriste merged 6 commits intoSep 7, 2026
Merged
Conversation
Keep the plan as a local-only working file rather than tracking it in the repo. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
cptanalatriste
marked this pull request as draft
September 3, 2026 15:28
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
cptanalatriste
marked this pull request as ready for review
September 3, 2026 15:55
llewelld
approved these changes
Sep 6, 2026
llewelld
left a comment
llewelld
left a comment
Contributor
There was a problem hiding this comment.
Nice work. The changes all look very sensible and align with what I'd expect to be needed for the guacamole-user-sync functionality you've added. I've not deployed an SRE myself to test this but am confident that the tests you describe in the description look sufficient.
The new tests are also nice. I added a few comments, but none of them are critical, so I'm approving as well.
cptanalatriste
merged commit Sep 7, 2026
3143c83
into
alan-turing-institute:develop
10 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ Checklist
Enable foobar integrationrather than515 foobar).develop.🚦 Depends on
N/A
As previously reported, TRE users experienced Guacamole connections randomly disappearing (see: #2480 ). Our analysis showed the problem was originated due to a bug in the
guacamole-user-synccontainer, that was finally addressed in versionv0.8.1(see: https://github.com/alan-turing-institute/guacamole-user-sync/pull/32/changes and alan-turing-institute/guacamole-user-sync#35).The current PR updates DSH to support
guacamole-user-syncnew version. Inv0.8.1, is required to pass each groups permissions via environment variables so they can be restored (details at: https://github.com/alan-turing-institute/guacamole-user-sync/blob/main/README.md ).🌂 Related issues
Closes: #2480
🔬 Tests
We have added some automated tests to verify that the container has the right versions and that each group's permissions are properly configured. The changes also include a refactoring of the existing test suite.
We also performed the following verification in a test deployment:
guacamole_connection_permissionstable, as described in Guacamole connections randomly dissapear #2480guacamole-user-syncprocess runs again. Currently, it runs every 5 minutes.