Feat: Add configurable LDAP group member attribute and single-run mode (#29) - #30
Open
LorenzoGParisi wants to merge 1 commit into
Open
Feat: Add configurable LDAP group member attribute and single-run mode (#29)#30LorenzoGParisi wants to merge 1 commit into
LorenzoGParisi wants to merge 1 commit into
Conversation
LorenzoGParisi
force-pushed
the
feature/issue-29
branch
from
April 8, 2026 19:59
bd61286 to
d35253a
Compare
Contributor
|
My apologies, @LorenzoGParisi, for not having looked at your PR earlier. Despite this, we really appreciate your contribution and especially the fact that you've gone to some lengths to ensure backwards compatibility. It looks like your changes may now be subsumed into #33. It would be good to have your thoughts on @sylvesterkaczmarek's changes, so please do feel free to add your comments to the PR. |
sylvesterkaczmarek
added a commit
to sylvesterkaczmarek/guacamole-user-sync
that referenced
this pull request
Aug 24, 2026
- add LDAP_GROUP_MEMBER_ATTR with a backward-compatible memberUid default - normalise UID-based LDAP distinguished-name members before user matching - tolerate missing optional LDAP membership/display attributes - add SINGLE_RUN_MODE with non-zero exit status on failed synchronisation - document single-run interaction with REPEAT_INTERVAL - add regression coverage for LDAP attribute variants and single-run success/failure Incorporates compatible behaviour from alan-turing-institute#30 following maintainer review. Co-authored-by: LorenzoGParisi <117413030+LorenzoGParisi@users.noreply.github.com>
sylvesterkaczmarek
added a commit
to sylvesterkaczmarek/guacamole-user-sync
that referenced
this pull request
Aug 25, 2026
- add LDAP_GROUP_MEMBER_ATTR with a backward-compatible memberUid default - normalise UID-based LDAP distinguished-name members before user matching - tolerate missing optional LDAP membership/display attributes - add SINGLE_RUN_MODE with non-zero exit status on failed synchronisation - preserve GUACAMOLE_GROUP_PERMISSIONS behaviour introduced by alan-turing-institute#32 - document single-run interaction with REPEAT_INTERVAL - add regression coverage for LDAP attribute variants and single-run success/failure Incorporates compatible behaviour from alan-turing-institute#30 following maintainer review and is rebased onto alan-turing-institute#32. Co-authored-by: LorenzoGParisi <117413030+LorenzoGParisi@users.noreply.github.com>
Author
|
Thanks, Lorenzo — appreciate you taking the time to look over #33, and glad the combined change works from your side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR addresses the limitations identified in #29 regarding LDAP compatibility and process lifecycle control.
Changes
SINGLE_RUN_MODEenvironment variable. When set totrue, the synchronizer performs one full cycle (LDAP to PostgreSQL) and exits. This is specifically designed for kubernetes cronjobs.memberUidwith a new environment variableLDAP_GROUP_MEMBER_ATTR. This enables compatibility with different directory structures like FreeIPA. The default value maintains backward compatibility with existing setups.Closes #29