Skip to content

Add missing src directory to build - #3921

Merged
westonruter merged 1 commit into
developfrom
add/src-to-build
Dec 12, 2019
Merged

Add missing src directory to build#3921
westonruter merged 1 commit into
developfrom
add/src-to-build

Conversation

@westonruter

@westonruter westonruter commented Dec 12, 2019

Copy link
Copy Markdown
Member

When deploying the ZIP to a site, I was seeing errors like this:

Fatal error: Uncaught Error: Class 'Amp\AmpWP\Component\DOMElementList' not found in /srv/bindings/842e702ecb134f309437791560d11313/code/wp-content/plugins/amp/includes/sanitizers/class-amp-gallery-block-sanitizer.php:109
Stack trace:
#0 /srv/bindings/842e702ecb134f309437791560d11313/code/wp-content/plugins/amp/includes/templates/class-amp-content-sanitizer.php(117): AMP_Gallery_Block_Sanitizer->sanitize()
#1 /srv/bindings/842e702ecb134f309437791560d11313/code/wp-content/plugins/amp/includes/class-amp-theme-support.php(2315): AMP_Content_Sanitizer::sanitize_document(Object(DOMDocument), Array, Array)
#2 /srv/bindings/842e702ecb134f309437791560d11313/code/wp-content/plugins/amp/includes/class-amp-theme-support.php(2003): AMP_Theme_Support::prepare_response('<!DOCTYPE html>...')
#3 [internal function]: AMP_Theme_Support::finish_output_buffering('<!DOCTYPE html>...', 9)
#4 /srv/bindings/842e702ecb134f309437791560d11313/code/wp-includes/functions.php(4469): ob_end_flush()
#5 /srv/bindings/842e702ecb134f309437791560d11313/code in /srv/bindings/842e702ecb134f309437791560d11313/code/wp-content/plugins/amp/includes/sanitizers/class-amp-gallery-block-sanitizer.php on line 109

The reason is the src directory was not flagged for being included in the build ZIP after #3659.

@westonruter westonruter added the Bug Something isn't working label Dec 12, 2019
@westonruter westonruter added this to the v1.5 milestone Dec 12, 2019
@westonruter
westonruter requested a review from pierlon December 12, 2019 00:18
@googlebot googlebot added the cla: yes Signed the Google CLA label Dec 12, 2019
@westonruter westonruter mentioned this pull request Dec 12, 2019
Closed
pierlon
pierlon approved these changes Dec 12, 2019
View reviewed changes

@pierlon pierlon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, :shipit: .

@westonruter
westonruter merged commit 1858e05 into develop Dec 12, 2019
@westonruter
westonruter deleted the add/src-to-build branch December 12, 2019 00:50
@kienstra

kienstra commented Dec 12, 2019

Copy link
Copy Markdown
Contributor

Thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@pierlon pierlon pierlon approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Bug Something isn't working cla: yes Signed the Google CLA

Projects

None yet

Milestone

v1.5

Development

Successfully merging this pull request may close these issues.

4 participants

@westonruter @kienstra @pierlon @googlebot