Remove Composer suggestion for ext-json - #4460
Merged
Merged
Conversation
Collaborator
Author
|
Failed tests with a GH issue: https://travis-ci.org/github/ampproject/amp-wp/jobs/667645959?utm_medium=notification&utm_source=github_status Restarting that test probably resolves the issue, and it should be unrelated anyway. |
westonruter
approved these changes
Mar 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In e196c44#diff-b5d0ee8c97c7abd7e3fa29b9a27d1780R13 , the PHP
jsonextension was added to the list of required extension.However, it was already container in the listed of suggested extensions, and not removed during that PR.
This PR removes the suggestion, as it is a requirement now.
Checklist