Keep MSGraph pagination offset across paginated pages - #71986
Draft
FrankYang0529 wants to merge 1 commit into
Draft
Keep MSGraph pagination offset across paginated pages#71986FrankYang0529 wants to merge 1 commit into
FrankYang0529 wants to merge 1 commit into
Conversation
Signed-off-by: PoAn Yang <payang@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
default_pagination()recovered the$skipoffset withsum(len(result["value"]) for result in responses()).result_processoraslambda result, **context: result.get("value").append_result()then extends the accumulator with the page's items, so XCom holds bare messages and those have no"value"key. On the deferrable pathresponses()reads exactly that XCom, so the run dies withKeyError: 'value'once a second full page arrives.How
$skipfrom the query parameters the page was requested with, so the offset no longer depends on what a user callback left in XCom. The same expression fixes the off-by-one page inpaginated_run()and keeps a user-supplied starting offset.defer(kwargs=...)and restore them inexecute_complete().Verification
uv run --project providers/microsoft/azure --frozen pytest providers/microsoft/azure/tests/unit -qWas generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.