[fix](fe) Reject conflicting path partition columns - #67408
Open
0AyanamiRei wants to merge 1 commit into
Open
Conversation
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: A file table-valued function could append a path partition column whose name already existed in the inferred file schema. The duplicate schema made direct column references ambiguous and allowed SELECT * to reach an internal backend error. Reject case-insensitive conflicts while constructing the schema so the invalid configuration fails during analysis.
### Release note
File table-valued functions now reject path partition columns that conflict with existing file columns.
### Check List (For Author)
- Test: Regression test and manual test
- Regression test: test_path_partition_column_collision
- Manual test: DESC FUNCTION and SELECT * with a conflicting local CSV path partition
- Behavior changed: Yes. Conflicting path partition columns now return a clear analysis error.
- Does this need documentation: No
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
TPC-H: Total hot run time: 16892 ms |
Contributor
TPC-DS: Total hot run time: 81066 ms |
Contributor
ClickBench: Total hot run time: 14.55 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
Author
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: A file table-valued function could append a path partition column whose name already existed in the inferred file schema. The duplicate schema made direct column references ambiguous and allowed
SELECT *to reach an internal backend error. Reject case-insensitive conflicts while constructing the schema so the invalid configuration fails during analysis.Release note
File table-valued functions now reject path partition columns that conflict with existing file columns.
Check List (For Author)
test_path_partition_column_collisionDESC FUNCTIONandSELECT *with a conflicting local CSV path partition