fix(throttling-manager): Normalize configured domains the same way as crawled hostnames - #2157
Open
Mantisus wants to merge 8 commits into
Open
fix(throttling-manager): Normalize configured domains the same way as crawled hostnames#2157Mantisus wants to merge 8 commits into
Mantisus wants to merge 8 commits into
Conversation
Collaborator
|
@janbuchar Does #2158 (comment) apply to this PR as well, or can this one be reviewed and merged? |
Collaborator
|
Also free to go, also will check later. |
Contributor
There was a problem hiding this comment.
Pull request overview
Normalizes configured throttling domains consistently with crawled hostnames.
Changes:
- Normalizes punycode, trailing dots, casing, and IPv6 literals.
- Rejects unreadable domain entries.
- Adds normalization and validation tests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/crawlee/request_loaders/_throttling_request_manager.py |
Adds domain parsing, normalization, and validation. |
tests/unit/test_throttling_request_manager.py |
Tests normalized matching and invalid input. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
domainsnow go through the same URL parsing and normalization as crawled URLs, so punycode, root-dotted and IPv6 spellings match. An entry the parser cannot read now raisesValueErrorinstead of silently matching nothing.Issues
ThrottlingRequestManagerdomain matching misses punycode, trailing dots and IPv6 literals #2144Testing