Skip to content

Fix Apple Silicon build - #2915

Open
Willem871 wants to merge 1 commit into
appleseedhq:masterfrom
Willem871:master
Open

Fix Apple Silicon build#2915
Willem871 wants to merge 1 commit into
appleseedhq:masterfrom
Willem871:master

Conversation

@Willem871

Copy link
Copy Markdown

Only include x86 specific headers and code when APPLESEED_X86 is defined.
This fixes the build of system.cpp on Apple Silicon.

Only include x86 specific headers and code when APPLESEED_X86 is defined.
This fixes builds on Apple Silicon.
@pjessesco

Copy link
Copy Markdown
Member

Hi @Willem871 , is it possible to build on macOS in current master branch??

It would be nice if you can share how you build on recent version of macOS.

@Willem871

Copy link
Copy Markdown
Author

Hi @pjessesco. We use the master branch of commit a6de6fb5c9618b2523d9b5eb4f8f4d9311234c53.
We have working macOS (Big Sur) builds (both Intel and ARM).
Next to this fix we also needed the sse2neon library to convert the SSE instructions in src/appleseed/foundation/platform/sse.h to NEON on ARM architectures. We didn't submit a pull request for this one, since we had to do some custom tweaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants