Skip to content

fix(emails): #679 SubscriptionErrorEmail is never sent #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LucBanda wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(emails): #679 SubscriptionErrorEmail is never sent #680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/backend/apps/finances/tests/test_webhooks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ def test_send_email_on_invoice_payment_failed(self, send_email, webhook_event_fa
webhook_event.invoke_webhook_handlers()

send_email.apply_async.assert_called_with(
(subscription.customer.subscriber.email, notifications.SubscriptionErrorEmail.name, None)
(subscription.customer.subscriber.email, notifications.SubscriptionErrorEmail.name, {})
)

@patch('common.emails.send_email')
Expand All @@ -113,7 +113,7 @@ def test_send_email_on_invoice_payment_required(self, send_email, webhook_event_
webhook_event.invoke_webhook_handlers()

send_email.apply_async.assert_called_with(
(subscription.customer.subscriber.email, notifications.SubscriptionErrorEmail.name, None)
(subscription.customer.subscriber.email, notifications.SubscriptionErrorEmail.name, {})
)


Expand Down
2 changes: 1 addition & 1 deletion packages/backend/common/emails.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def __init__(self, to, data=None):
self.data = {}

def send(self, due_date=None):
send_data = None
send_data = {}

serializer = self.get_serializer(data=self.data)
if serializer:
Expand Down