Skip to content

fix: create artifact plugin socket dir before starting the plugin server. Fixes #16784 #16785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
myzk-a wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: create artifact plugin socket dir before starting the plugin server. Fixes #16784 #16785

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions cmd/argoexec/commands/artifact_plugin_init.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,15 @@ func NewArtifactPluginInitCommand() *cobra.Command {
containerName := os.Getenv(common.EnvVarContainerName)
includeScriptOutput := os.Getenv(common.EnvVarIncludeScriptOutput) == "true"

// The plugin server binds its socket inside this directory, so it has to exist
// before the server starts. If the server wins that race, bind() fails with
// ENOENT, the server exits, and the load below waits out its full 120s timeout
// for a socket that can never appear.
pluginName := wfv1.ArtifactPluginName(artifactPlugin)
if err := os.MkdirAll(pluginName.SocketDir(), 0o755); err != nil {
return fmt.Errorf("failed to create artifact plugin socket directory: %w", err)
}

name, args := args[0], args[1:]
logger.WithFields(logging.Fields{"name": name, "args": args}).Debug(ctx, "starting command")

Expand All @@ -44,7 +53,7 @@ func NewArtifactPluginInitCommand() *cobra.Command {

forwardSignals(ctx, signals, command.Process.Pid, false)
}()
err := loadArtifactPlugin(ctx, wfv1.ArtifactPluginName(artifactPlugin))
err := loadArtifactPlugin(ctx, pluginName)
if err != nil {
return fmt.Errorf("%w", err)
}
Expand All @@ -56,9 +65,6 @@ func NewArtifactPluginInitCommand() *cobra.Command {
}

func loadArtifactPlugin(ctx context.Context, pluginName wfv1.ArtifactPluginName) error {
if err := os.MkdirAll(pluginName.SocketDir(), 0755); err != nil {
return err
}
wfExecutor := executor.Init(ctx, clientConfig, varRunArgo)
errHandler := wfExecutor.HandleError(ctx)
defer errHandler()
Expand Down