Skip to content

fix: mark TaskGroup as Skipped when all children skipped/omitted by when-clause #16803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
waterWang wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: mark TaskGroup as Skipped when all children skipped/omitted by when-clause #16803

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions workflow/controller/dag.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -702,6 +702,7 @@ func (woc *wfOperationCtx) executeDAGTask(ctx context.Context, dagCtx *dagContex

if taskGroupNode != nil {
groupPhase := wfv1.NodeSucceeded
allSkipped := true
for _, t := range expandedTasks {
// Add the child relationship from our dependency's outbound nodes to this node.
node := dagCtx.getTaskNode(ctx, t.Name)
Expand All @@ -711,6 +712,16 @@ func (woc *wfOperationCtx) executeDAGTask(ctx context.Context, dagCtx *dagContex
if node.FailedOrError() {
groupPhase = node.Phase
}
if node.Phase != wfv1.NodeSkipped && node.Phase != wfv1.NodeOmitted {
allSkipped = false
}
}
// A task group whose every child was skipped/omitted (e.g. a withParam task whose
// when-clause filtered out every item) produced no outputs. Mark the group itself
// Skipped so addSkippedNodeOutputsToScope populates its declared output defaults
// and downstream references resolve instead of leaving the workflow stuck.
if allSkipped && len(expandedTasks) > 0 {
groupPhase = wfv1.NodeSkipped
}
woc.markNodePhase(ctx, taskGroupNode.Name, groupPhase)
}
Expand Down
Loading