chore(deps): update dagre to @dagrejs/dagre v3.1.1 - #16836
Conversation
Replace the unmaintained unscoped dagre@0.8.5 (and @types/dagre) with @dagrejs/dagre@3.1.1, which ships its own TypeScript types and drops the lodash dependency. Instantiate the layout graph with dagre's own label types since the new Graph generics default to any. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01E6uCkYGPcvx4qighMPonGz Signed-off-by: Alan Clucas <alan@clucas.org>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe UI replaces ChangesDagre migration
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This localized UI dependency update changes the graph library and its import while preserving layout behavior; lint, tests, build, and live DAG rendering pass, so no actionable merge-blocking risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Description checkExplanation The description covers the required motivation, modifications, verification, documentation, AI disclosure, and checklist items. The unchecked pre-commit item includes a clear explanation, and the omitted issue reference is non-critical for this dependency-only change. Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
See the pull request guide for details on each item.
make pre-commit -B—make lintpasses;codegen/docscould not run in my environment (nobuf/markdownlint); neither is relevant to a UI-only dependency changemake feature-new) — n/a, not a featureMotivation
The UI's graph layout uses
dagre@0.8.5, the last release of the unscoped package (2019). The project moved to@dagrejs/dagre, currently 3.1.1. The new package ships its own TypeScript types, so@types/dagregoes too, and it no longer depends onlodash.Dependency checks: MIT licensed, actively maintained (3.1.1 released 2026-08-08),
yarn auditclean.Modifications
ui/package.json,ui/yarn.lock:dagre+@types/dagre→@dagrejs/dagre@^3.1.1(pulls@dagrejs/graphlib@4.0.5; dropsgraphlib@2).ui/src/shared/components/graph/pretty-layout.ts: import from@dagrejs/dagre; instantiateGraphwith dagre'sGraphLabel/NodeLabel/EdgeLabelgenerics (they default toany, which trippednoImplicitAnyonedge().points). No layout API changes were needed.Rendered against a live cluster, 351-node DAG:
Verification
yarn lint,yarn test(28 suites),yarn buildall pass.Documentation
None needed — internal UI dependency.
AI
Claude Code (Claude Fable 5) produced the change, ran the verification, and drafted this description; reviewed by the author.
Summary by CodeRabbit