Conversation
add vs for webserver
Contributor
|
@htech7x git sync relay virtualhost missing we are using that for receiving webhook |
Contributor
|
added missing gitsync templates for webhook |
Contributor
|
2 decisions instead of airflow.istio.enabled should we move to istio.enabled making it as astronomer managed |
pgvishnuram
approved these changes
Jul 6, 2026
There was a problem hiding this comment.
Pull request overview
Adds optional Istio ingress support to the Airflow Helm chart by introducing Istio VirtualService resources for UI/API and related endpoints, and conditionally disabling certain Kubernetes Ingress resources when Istio is enabled.
Changes:
- Introduces
airflow.istio.enabledflag invalues.yaml. - Adds Istio
VirtualServicetemplates for webserver (Airflow <3), API server (Airflow >=3), Flower, DAG server, and git-sync-relay webhook. - Prevents creating some Kubernetes
Ingressresources when Istio is enabled (dag-server and git-sync-relay webhook ingress).
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| values.yaml | Adds airflow.istio.enabled configuration toggle. |
| templates/webserver/webserver-virtualservice.yaml | Adds Istio VirtualService for Airflow webserver routing. |
| templates/api-server/api-server-virtualservice.yaml | Adds Istio VirtualService for Airflow API server routing (Airflow >=3). |
| templates/flower/flower-virtualservice.yaml | Adds Istio VirtualService for Flower routing (CeleryExecutor). |
| templates/dag-deploy/dag-server-virtualservice.yaml | Adds Istio VirtualService for DAG server routing. |
| templates/git-sync-relay/git-sync-relay-virtualservice.yaml | Adds Istio VirtualService for git-sync-relay webhook routing. |
| templates/ingress.yaml | Disables dag-server Ingress when Istio is enabled. |
| templates/git-sync-relay/git-sync-relay-ingress.yaml | Disables git-sync-relay webhook Ingress when Istio is enabled. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| {{- end }} | ||
| {{- end }} | ||
| {{- if and .Values.dagDeploy.enabled }} | ||
| {{- if and .Values.dagDeploy.enabled (not .Values.airflow.istio.enabled) }} |
Comment on lines
+6
to
+8
| # istio config section | ||
| istio: | ||
| enabled: false |
Comment on lines
+45
to
+56
| hosts: | ||
| - {{- include "deployments_subdomain" . | indent 1 }} | ||
| {{- if hasKey .Values.airflow.istio "gateway" }} | ||
| gateways: | ||
| - {{ .Values.airflow.istio.gateway }} | ||
| {{- end }} | ||
| http: | ||
| # Webserver routes | ||
| - match: | ||
| - uri: | ||
| prefix: "/{{ .Release.Name }}/airflow" | ||
| route: |
Comment on lines
+47
to
+50
| {{- if hasKey .Values.airflow.istio "gateway" }} | ||
| gateways: | ||
| - {{ .Values.airflow.istio.gateway }} | ||
| {{- end }} |
Comment on lines
+23
to
+25
| {{- if and .Values.airflow.istio.enabled (semverCompare "<3.0.0" .Values.airflow.airflowVersion) }} | ||
| {{- $fullname := include "airflow.fullname" . }} | ||
| apiVersion: networking.istio.io/v1 |
Comment on lines
+45
to
+56
| hosts: | ||
| - {{- include "deployments_subdomain" . | indent 1 }} | ||
| {{- if hasKey .Values.airflow.istio "gateway" }} | ||
| gateways: | ||
| - {{ .Values.airflow.istio.gateway }} | ||
| {{- end }} | ||
| http: | ||
| # API Server routes | ||
| - match: | ||
| - uri: | ||
| prefix: "/{{ .Release.Name }}/airflow" | ||
| route: |
Comment on lines
+47
to
+50
| {{- if hasKey .Values.airflow.istio "gateway" }} | ||
| gateways: | ||
| - {{ .Values.airflow.istio.gateway }} | ||
| {{- end }} |
Comment on lines
+47
to
+50
| {{- if hasKey .Values.airflow.istio "gateway" }} | ||
| gateways: | ||
| - {{ .Values.airflow.istio.gateway }} | ||
| {{- end }} |
Comment on lines
+47
to
+50
| {{- if hasKey .Values.airflow.istio "gateway" }} | ||
| gateways: | ||
| - {{ .Values.airflow.istio.gateway }} | ||
| {{- end }} |
| {{- end }} | ||
| {{- end }} | ||
| {{- if and .Values.dagDeploy.enabled }} | ||
| {{- if and .Values.dagDeploy.enabled (not .Values.airflow.istio.enabled) }} |
Comment on lines
4
to
8
| {{- if and | ||
| .Values.gitSyncRelay.enabled | ||
| (eq .Values.gitSyncRelay.repoFetchMode "webhook") | ||
| (not .Values.airflow.istio.enabled) | ||
| }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding support for Istio ingress
Related Issues
https://linear.app/astronomer/issue/APC-1423/add-optional-istio-ingress-support-to-apc-helm-chart
Testing
Testing was conducted for APC 1.1.5 in unified mode.
Merging