Skip to content
Node.js CI

revert to basic caged shapes for minor because major is still broken #199

Sign in to view logs

revert to basic caged shapes for minor because major is still broken

revert to basic caged shapes for minor because major is still broken #199

Triggered via push December 27, 2025 15:16
@cagedcaged
pushed dbb05ab
position-systems
Status Failure
Total duration 1m 2s
Artifacts –

node.js.yml

on: push
Matrix: build
Fit to window
Zoom out
Zoom in

Annotations

10 errors
src/frets/index.test.js > fretboard tests > note normalization for scales > does not normalize sharps for G# major scale: src/frets/index.test.js#L228
AssertionError: expected [] to include 'G#' ❯ src/frets/index.test.js:228:27
src/frets/index.test.js > fretboard tests > note normalization for scales > shows all flat notes in Ab major scale intervals: src/frets/index.test.js#L215
AssertionError: expected [] to deeply equal [ 'Ab', 'Bb', 'C', 'Db', 'Eb', …(2) ] - Expected + Received - [ - "Ab", - "Bb", - "C", - "Db", - "Eb", - "F", - "G", - ] + [] ❯ src/frets/index.test.js:215:34
src/frets/index.test.js > fretboard tests > note normalization for scales > normalizes to flats for Ab major scale: src/frets/index.test.js#L203
AssertionError: expected 'G♯' to be 'Ab' // Object.is equality Expected: "Ab" Received: "G♯" ❯ src/frets/index.test.js:203:37
src/frets/index.test.js > fretboard tests > alternative tunings > works with 4-string bass tuning: src/frets/index.test.js#L159
AssertionError: expected 'G2' to be 'E1' // Object.is equality Expected: "E1" Received: "G2" ❯ src/frets/index.test.js:159:37
src/frets/index.test.js > fretboard tests > alternative tunings > works with 7-string tuning: src/frets/index.test.js#L150
AssertionError: expected 'E4' to be 'B1' // Object.is equality Expected: "B1" Received: "E4" ❯ src/frets/index.test.js:150:37
src/frets/index.test.js > fretboard tests > alternative tunings > works with DADGAD tuning: src/frets/index.test.js#L139
AssertionError: expected 'D4' to be 'D2' // Object.is equality Expected: "D2" Received: "D4" ❯ src/frets/index.test.js:139:37
src/frets/index.test.js > fretboard tests > alternative tunings > works with drop D tuning: src/frets/index.test.js#L130
AssertionError: expected 'E4' to be 'D2' // Object.is equality Expected: "D2" Received: "E4" ❯ src/frets/index.test.js:130:37
src/frets/index.test.js > fretboard tests > notes generation > generates correct notes at specific fret positions: src/frets/index.test.js#L118
AssertionError: expected 'E4' to be 'E2' // Object.is equality Expected: "E2" Received: "E4" ❯ src/frets/index.test.js:118:37
src/frets/index.test.js > fretboard tests > notes generation > generates all 6 strings for standard tuning: src/frets/index.test.js#L105
AssertionError: expected 'E4' to be 'E2' // Object.is equality Expected: "E2" Received: "E4" ❯ src/frets/index.test.js:105:37
src/frets/index.test.js > fretboard tests > notes generation > generates correct start notes for each string: src/frets/index.test.js#L52
AssertionError: expected 'E4' to be 'E2' // Object.is equality Expected: "E2" Received: "E4" ❯ src/frets/index.test.js:52:39 ❯ src/frets/index.test.js:51:17