Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #347 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 13 +1
Lines 886 960 +74
Branches 151 163 +12
=========================================
+ Hits 886 960 +74
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Add a ProxyProtocol config class and a proxy_protocol keyword on SMTP, SMTP.connect, and send. Supports v1 (text) and v2 (binary) headers, with v2 the default; the header is written before the SMTP banner is read, including ahead of the TLS handshake when use_tls=True. Also fixes SMTP.quit() hanging until the read timeout when the peer drops the transport after QUIT is sent but before the 221 reply is parsed, and factors the TLS transport upgrade into SMTPProtocol.upgrade_transport, shared by STARTTLS and the deferred proxy+TLS connect path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.