feat(appimage): more useful error message

[mrcjkb]

I found the error message when executing the AppImage build script a bit confusing (also, the name of the script in the error message is wrong).

This PR adds the full path to the script.

[FabianLars-crabnebula]

thanks for the pr :)

[FabianLars-crabnebula]

I wonder whether we should just keep it with the debug log https://github.com/mrcjkb/cargo-packager/blob/ac7495aab7eaee0fb10514a24cf56721b5a5940f/crates/packager/src/package/appimage/mod.rs#L193
I don't see much value in adding the path to the error directly if we log it anyway tbh.

Still a bit unhappy about a breaking change just for this tbh

[mrcjkb]

Another alternative without introducing a breaking change could be to use io::Error::other:

.map_err(|err| io::Error::other(format!("Error running '{0}' script: {err}", sh_file.display())))
.map_err(crate::Error::AppImageScriptFailed)?;

[denjell-crabnebula]

Hey @FabianLars-crabnebula - why did this not get merged?

Ahhh. Because of the breaking change. Yeah, I agree. NO breaking changes for things like this.

[FabianLars-crabnebula]

Another alternative without introducing a breaking change could be to use io::Error::other:

What would the error look like then on the dev/user side? At first glance I would have expected the io error to be lost in the conversion, is it not?

[mrcjkb]

Another alternative without introducing a breaking change could be to use io::Error::other:

What would the error look like then on the dev/user side? At first glance I would have expected the io error to be lost in the conversion, is it not?

If for some reason one wanted to pattern match on the underlying io::Error, then yes, it would be lost. The error is encoded via its Display instance.

[FabianLars-crabnebula]

oops i missed the {err} on my phone. I think we can go with this approach until i migrate the rust rewrite i did in tauri-bundler over here.

[FabianLars-crabnebula]

Ah, you'll need to sign your commits for me to merge this, sorry.

https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

[FabianLars-crabnebula]

Actually we queued a few breaking dependency updates so we can break the error enum as well but tbh i kinda prefer this new way.

[mrcjkb]

Ah, you'll need to sign your commits for me to merge this, sorry.

docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

Hmm, it looks like the original commit was with an old e-mail address I no longer use and jj doesn't appear to be updating it.

Edit: Fixed.

[FabianLars-crabnebula]

thanks!