Restore chaos65204782cs as a standalone JIT test - #133039
Open
steveisok wants to merge 1 commit into
Open
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
the
area-CodeGen-coreclr
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
Review tier: Lite
Findings: None
What changed in this PR
This PR moves chaos65204782cs out of the merged JIT.Generics runner assemblies and restores it as a standalone, process-isolated test project that can be selectively excluded from Mono FullAOT variants without disabling the merged runners.
Changes:
- Remove
Coverage\chaos65204782cs.csfrom the merged runner compile lists. - Add a standalone
Coverage\chaos65204782cs.csprojmarkedRequiresProcessIsolationandMonoAotIncompatible. - Reference the standalone project from the
JIT.GenericsPdbOnly runner viaMergedWrapperProjectReference.
| File | Description |
|---|---|
| src/tests/JIT/Generics/JIT.Generics.csproj | Stops compiling chaos65204782cs.cs into the merged runner; adds a wrapper project reference to build it as an out-of-process test. |
| src/tests/JIT/Generics/JIT.Generics_ro.csproj | Stops compiling chaos65204782cs.cs into the optimized merged runner. |
| src/tests/JIT/Generics/Coverage/chaos65204782cs.csproj | Reintroduces chaos65204782cs as a standalone process-isolated test, marked MonoAotIncompatible for Mono AOT variants. |
This was referenced Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #132167 compiled
chaos65204782cs.csinto both mergedJIT.Genericsrunners. Mono FullAOT rejects its recursive generic metadata, causing the entire runners to fail AOT compilation.Restore the dedicated test project and:
JIT.Genericsrunners enabled for FullAOT coverageThe standalone project remains referenced by the PdbOnly runner so it participates in normal test execution.
Validation
MSBuild evaluation confirmed:
The full build was not run because the pinned SDK was unavailable from its feeds.
Addresses #132942 without closing it, since the issue also tracks the underlying Mono AOT recursion failure.
Note
This pull request description was generated with GitHub Copilot.
Fixes: #132942