admin: Streaming version of /config_dump - #46911
Open
filipcacky wants to merge 6 commits into
Open
Conversation
Contributor
Author
|
This impl suffers a bit from small allocations while printing the JSON, which can be remedied by using I tried to reduce the number of allocations in the Let me know if you'd like me to split this to two PRs, one with the proto printer and another with the rest. |
filipcacky
force-pushed
the
config_streamed
branch
2 times, most recently
from
August 24, 2026 22:44
4a6f7b7 to
b6d8411
Compare
Signed-off-by: Filip Cacky <filip.cacky@cdn77.com>
Signed-off-by: Filip Cacky <filip.cacky@cdn77.com>
Signed-off-by: Filip Cacky <filip.cacky@cdn77.com>
Signed-off-by: Filip Cacky <filip.cacky@cdn77.com>
Signed-off-by: Filip Cacky <filip.cacky@cdn77.com>
Signed-off-by: Filip Cacky <filip.cacky@cdn77.com>
filipcacky
force-pushed
the
config_streamed
branch
from
August 25, 2026 00:37
c954a60 to
7b99f0c
Compare
Contributor
Author
|
/retest |
filipcacky
marked this pull request as ready for review
August 25, 2026 11:15
Contributor
Author
|
cc @jmarantz |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: admin: Streaming version of /config_dump
Additional Description:
Implements streaming version of /config_dump. Each tracked config name is snapshotted at the start and the config is materialized only when it is being serialized. The serialization is done by walking a protobuf with reflection, redacting sensitive fields as they are visited.
Compared to the previous version, this one can't do pretty printing.
Also adds
Envoy::Json::MessageStreamerandEnvoy::ProtoFilller:fill(). The message streamer is what implements the reflection walk and serialization to json. Thefillutility allows for filling arbitrary protobuf objects with non-default values for performance tests.Used AI to bootstrap tests, check comments and doublecheck the ProtoJSON impl against docs, as well as the occasional simplify pass.
Risk Level: Medium, rewrites
/config_dumpadmin endpointTesting: Unit tests in
proto_streamer_test.ccandconfig_dump_handler_test.cc, perf tests, manual withconfigs/envoy-demo.yamlDocs Changes: N/A
Release Notes: <TODO maybe mention the no pretty printing?>
Platform Specific Features: N/A
[Optional Runtime guard:]
Fixes #32054
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]