mcp: Never reject requests during passthrough mode. - #46924
Open
mkbehr wants to merge 1 commit into
Open
Conversation
Signed-off-by: Michael Behr <mkbehr@google.com>
Contributor
Author
|
/assign tyxia |
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: mcp: Never reject requests during passthrough mode.
Additional Description:
McpFilterno longer rejects any requests inPASS_THROUGHmode. Previously, the filter could reject requests in some cases when it failed to parse the request as an MCP request. Parse failures are now recorded in the filter's dynamic metadata, underpassthrough_reason.Risk Level: Low; bugfix to bring behavior in line with API documentation. Not config-guarded.
Testing: Unit and integration tests
Docs Changes: n/a
Release Notes: yes
Platform Specific Features: n/a
Generative AI was used to create this change. I have manually reviewed and fully understand it.