rust: disable uploading incremental compilation build artifacts - #1474
rust: disable uploading incremental compilation build artifacts#1474davidbarsky wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
This pull request has been imported. If you are a Meta employee, you can view this in D117392553. (Because this pull request was imported automatically, there will not be any future comments.) |
8Keep
left a comment
8Keep
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Summary: I enabled incremental compilation with Rust and noticed that incremental compilation artifacts were being uploading, negating (and worse, regressing!) build times due to cache uploads. I then went down a rabbit hole, which... well, you can see in the comment I wrote. X-link: facebook/buck2#1474 Reviewed By: capickett, 8Keep Differential Revision: D117392553 fbshipit-source-id: 02e9272a62f1ccbe46f1a17e788f3c0ae12b6ec0
|
This pull request has been merged in d1fc5f2. |
|
We don't run into this internally because we don't upload any artifacts from user builds, only trunk builds. We consider user builds unsafe to upload because someone could modify outputs before uploading, we can't trust users. User artifacts are uploaded as part of running them on RE, because other users will only get those artifacts if they have the exact same inputs (inputs is part of the key for the remote action). So, user builds populate caches only through remote actions, and trusted CI machines are the only ones who can upload local only actions. PR makes sense, just wanted to clarify why we do not hit this internally. |
2 participants
I enabled incremental compilation with Rust and noticed that incremental compilation artifacts were being uploading, negating (and worse, regressing!) build times due to cache uploads. I then went down a rabbit hole, which... well, you can see in the comment I wrote.