Code Quality: Remove unused analyzer for localization resources - #18844
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes an unused localization-related analyzer/code fix from the Files.Core.SourceGenerator project to reduce maintenance surface and dependencies within the source-generator/analyzer component of the codebase.
Changes:
- Deleted the
StringsPropertyAnalyzer(FSG1002) and its correspondingStringsPropertyCodeFixProvider. - Removed the FSG1002 diagnostic descriptor and related constants from
Constants.cs. - Dropped now-unneeded global usings and the
Microsoft.CodeAnalysis.Workspaces.Commonpackage reference, and updated analyzer release tracking to remove FSG1002.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Files.Core.SourceGenerator/GlobalUsings.cs | Removes global usings that were only required by the deleted analyzer/code fix implementation. |
| src/Files.Core.SourceGenerator/Files.Core.SourceGenerator.csproj | Removes the Workspaces package dependency no longer needed after deleting the code fix/analyzer. |
| src/Files.Core.SourceGenerator/Constants.cs | Deletes FSG1002 descriptor and related constants used exclusively by the removed analyzer/code fix. |
| src/Files.Core.SourceGenerator/CodeFixProviders/StringsPropertyCodeFixProvider.cs | Deletes the unused code fix provider. |
| src/Files.Core.SourceGenerator/Analyzers/StringsPropertyAnalyzer.cs | Deletes the unused analyzer rule implementation. |
| src/Files.Core.SourceGenerator/AnalyzerReleases.Unshipped.md | Removes the FSG1002 entry from unshipped analyzer rule tracking. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
Author
|
it wasnt a good idea to put code fixers / analyzers in a codegen project and the project was emitting a warning but now we can delete them. |
Member
|
Please resolve conflicts and fill out the steps used to test these changes. |
0x5bfa
force-pushed
the
removeanalyzers
branch
from
August 19, 2026 20:55
5dc446f to
b4a5a91
Compare
Member
Author
|
@yair100 Done. |
yair100
self-requested a review
August 19, 2026 21:30
hez2010
approved these changes
Aug 19, 2026
Removed Microsoft.CodeAnalysis.Workspaces.Common package version.
hez2010
approved these changes
Aug 20, 2026
yair100
added
ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
None
Steps used to test these changes