Code Quality: Mask username and file paths from log file - #18846
Merged
Conversation
yair100
force-pushed
the
ya/log-privacy
branch
from
August 19, 2026 20:22
de753db to
8190f3c
Compare
yair100
force-pushed
the
ya/log-privacy
branch
from
August 19, 2026 20:32
a9fc8f4 to
f9f47ff
Compare
Josh65-2201
reviewed
Aug 19, 2026
Member
There was a problem hiding this comment.
Only have Google drive to test the user name filter. Seem it taking out the full path rather than just the user name
Adding cloud provider "Google Drive" mapped to C:\Users\Josh\Google Drive Streaming\My Drive
to
Adding cloud provider GoogleDrive mapped to [hash:d8dda600]
Would expected
C:\Users\[User name]\Google Drive Streaming\My Drive
yair100
force-pushed
the
ya/log-privacy
branch
from
August 19, 2026 21:20
f9f47ff to
777942c
Compare
Member
Author
|
@Josh65-2201 can you please check again?
|
Josh65-2201
previously approved these changes
Aug 20, 2026
0x5bfa
approved these changes
Aug 20, 2026
0x5bfa
left a comment
0x5bfa
left a comment
Member
There was a problem hiding this comment.
Code wise, LGTM. but what about emails?
Member
Author
|
@0x5bfa where do emails come up? |
Member
|
I just remembered this reply #16702 (comment) |
yair100
added
ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.