Skip to content

IPAFileCheck: also allow 640 for kra debug log - #375

Merged
rcritten merged 1 commit into
freeipa:masterfrom
flo-renaud:t374
Mar 16, 2026
Merged

IPAFileCheck: also allow 640 for kra debug log#375
rcritten merged 1 commit into
freeipa:masterfrom
flo-renaud:t374

Conversation

@flo-renaud

@flo-renaud flo-renaud commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

The check ipahealthcheck.ipa.files.IPAFileCheck reports an error with PKI 11.9.1 because this update changed the permissions on /var/log/pki/pki-tomcat/kar/debug.$DATE.log to 0640 instead of 0644.

Allow both values as we already do for CA debug log.

Fixes: #374

Summary by Sourcery

Bug Fixes:

  • Treat KRA tomcat debug log files with either 0644 or 0640 permissions as valid in IPA file health checks.

The check ipahealthcheck.ipa.files.IPAFileCheck reports an error
with PKI 11.9.1 because this update changed the permissions on
/var/log/pki/pki-tomcat/kar/debug.$DATE.log to 0640 instead of
0644.

Allow both values as we already do for CA debug log.

Fixes: freeipa#374
Signed-off-by: Florence Blanc-Renaud <flo@redhat.com>

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@rcritten rcritten added the ack label Mar 16, 2026
@rcritten

Copy link
Copy Markdown
Collaborator

Thanks, patch looks good.

@rcritten
rcritten merged commit 10c5da4 into freeipa:master Mar 16, 2026
8 checks passed
@flo-renaud
flo-renaud deleted the t374 branch March 16, 2026 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ipahealthcheck.ipa.files.IPAFileCheck ERROR: Permissions of /var/log/pki/pki-tomcat/kra/debug.log

2 participants