Correct the logic on trust checking in IPATrustPackageCheck - #379
Merged
Conversation
The check would be skipped if either not a trust controller or a trust agent. It should skip it if both conditions are true. This resulted in an incorrect message in the output because it skipped if the server was a controller. If it was not then the function exited without checking to see if it was an agent instead. Fixes: freeipa#378 Signed-off-by: Rob Crittenden <rcritten@redhat.com>
F42 was EOL in May, 2026. Signed-off-by: Rob Crittenden <rcritten@redhat.com>
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
rjeffman
approved these changes
May 4, 2026
rjeffman
left a comment
rjeffman
left a comment
Member
There was a problem hiding this comment.
LGTM. Fixes the referenced issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check would be skipped if either not a trust controller or
a trust agent. It should skip it if both conditions are true.
This resulted in an incorrect message in the output because it
skipped if the server was a controller. If it was not then
the function exited without checking to see if it was an agent
instead.
Fixes: #378
Signed-off-by: Rob Crittenden rcritten@redhat.com
Also update the Fedora versions to test against.
Summary by Sourcery
Fix trust role detection in IPATrustPackageCheck and update CI Fedora test matrix.
Bug Fixes:
CI: