Skip to content

feat(payment_terms): Apply nullability for net_payment_term - #6191

Open
D1353L wants to merge 2 commits into
feat-payment-terms-backfillfrom
feat-payment-terms-nullable-alias
Open

feat(payment_terms): Apply nullability for net_payment_term#6191
D1353L wants to merge 2 commits into
feat-payment-terms-backfillfrom
feat-payment-terms-nullable-alias

Conversation

@D1353L

@D1353L D1353L commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Context

The net_payment_term alias column doesn't have an equivalent for some new payment terms ("end_of_month", "day_of_month" etc.). In those cases, the alias should be null.

Description

  • Migration to allow null for the net_payment_term in billing_entities and invoices
  • GraphQL type updates to allow returning null to the frontend.

NOTE: the model validation kept restricting null and is changed in the following PR #6195. This is for safety when the current PR is released and the following one isn't. So we don't get net_payment_term: null too early, which could break due_date calculations.


Stack created with GitHub Stacks CLIGive Feedback 💬

@D1353L
D1353L force-pushed the feat-payment-terms-nullable-alias branch 2 times, most recently from c52ab86 to 534c49b Compare August 19, 2026 17:16
@D1353L
D1353L force-pushed the feat-payment-terms-nullable-alias branch 4 times, most recently from f6bfcdd to ac775f9 Compare August 21, 2026 14:53
@D1353L
D1353L force-pushed the feat-payment-terms-nullable-alias branch from ac775f9 to fe08cc7 Compare August 21, 2026 16:02
@D1353L
D1353L force-pushed the feat-payment-terms-nullable-alias branch from 43d5a65 to d5392fe Compare August 24, 2026 19:59
@D1353L
D1353L force-pushed the feat-payment-terms-nullable-alias branch from d5392fe to 189642d Compare August 25, 2026 13:09
@D1353L
D1353L force-pushed the feat-payment-terms-nullable-alias branch from 189642d to 1c4c635 Compare August 25, 2026 14:21
@D1353L
D1353L force-pushed the feat-payment-terms-nullable-alias branch from 1c4c635 to 9c2e26e Compare August 25, 2026 14:27
@D1353L
D1353L marked this pull request as ready for review August 25, 2026 14:51
@D1353L
D1353L force-pushed the feat-payment-terms-nullable-alias branch from 9c2e26e to a5eccf4 Compare August 26, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant