Skip to content

feat(billing): add the product-catalog date engine - #6267

Draft
brunomiguelpinto wants to merge 17 commits into
products-and-plans-subscription-runtimefrom
engine-dates
Draft

feat(billing): add the product-catalog date engine#6267
brunomiguelpinto wants to merge 17 commits into
products-and-plans-subscription-runtimefrom
engine-dates

Conversation

@brunomiguelpinto

@brunomiguelpinto brunomiguelpinto commented Sep 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No description provided.

@brunomiguelpinto brunomiguelpinto changed the title feat: cleaned the pr feat(billing): add the product-catalog date engine Sep 1, 2026
tiagolupepic
tiagolupepic reviewed Sep 1, 2026
View reviewed changes
Comment thread app/services/billing/schedules/build_service.rb Outdated
tiagolupepic
tiagolupepic reviewed Sep 1, 2026
View reviewed changes
Comment thread app/services/billing/schedules/build_service.rb Outdated
tiagolupepic
tiagolupepic reviewed Sep 1, 2026
View reviewed changes
Comment thread app/services/billing/calendar.rb Outdated
tiagolupepic
tiagolupepic reviewed Sep 1, 2026
View reviewed changes
Comment thread app/services/billing/schedule.rb Outdated
tiagolupepic
tiagolupepic reviewed Sep 1, 2026
View reviewed changes
Comment thread app/services/billing/schedule.rb Outdated
tiagolupepic
tiagolupepic reviewed Sep 1, 2026
View reviewed changes
Comment thread app/services/billing/segments.rb Outdated
tiagolupepic
tiagolupepic reviewed Sep 1, 2026
View reviewed changes
Comment thread app/services/billing/segments.rb Outdated
tiagolupepic
tiagolupepic reviewed Sep 1, 2026
View reviewed changes
Comment thread app/services/billing/segments.rb Outdated
annvelents
annvelents reviewed Sep 1, 2026
View reviewed changes
Comment thread db/migrate/20260901122946_create_billing_segments.rb
tiagolupepic
tiagolupepic reviewed Sep 1, 2026
View reviewed changes
Comment thread app/services/billing/segments.rb
tiagolupepic
tiagolupepic reviewed Sep 1, 2026
View reviewed changes
Comment thread app/services/subscriptions/product_catalog/materialize_service.rb Outdated
tiagolupepic
tiagolupepic reviewed Sep 1, 2026
View reviewed changes
Comment thread app/services/subscriptions/product_catalog/materialize_service.rb Outdated
annvelents
annvelents reviewed Sep 1, 2026
View reviewed changes
Comment thread app/services/subscriptions/product_catalog/materialize_service.rb Outdated
annvelents
annvelents reviewed Sep 1, 2026
View reviewed changes
Comment thread app/services/billing/interval.rb
annvelents
annvelents reviewed Sep 1, 2026
View reviewed changes
Comment thread app/services/billing/calendar.rb Outdated
annvelents
annvelents reviewed Sep 1, 2026
View reviewed changes
Comment thread app/services/billing/calendar.rb Outdated
annvelents
annvelents reviewed Sep 1, 2026
View reviewed changes
Comment thread app/services/billing/calendar.rb Outdated
annvelents
annvelents reviewed Sep 1, 2026
View reviewed changes
Comment thread app/services/billing/calendar.rb Outdated
annvelents
annvelents reviewed Sep 1, 2026
View reviewed changes
Comment thread app/services/billing/calendar.rb Outdated
annvelents
annvelents reviewed Sep 1, 2026
View reviewed changes
Comment thread app/services/billing/calendar.rb Outdated
annvelents
annvelents reviewed Sep 1, 2026
View reviewed changes
Comment thread app/services/billing/schedule.rb Outdated
annvelents
annvelents reviewed Sep 1, 2026
View reviewed changes
Comment thread app/services/billing/schedule.rb Outdated
annvelents
annvelents reviewed Sep 1, 2026
View reviewed changes
Comment thread app/services/billing/segments.rb Outdated
brunomiguelpinto
brunomiguelpinto commented Sep 1, 2026
View reviewed changes

@brunomiguelpinto brunomiguelpinto left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read it end to end. The pure layer is the strongest part — Interval, Calendar and Segments have no dependencies, and having the QA scenarios pinned as value tables means an expectation can be checked against the plan rather than argued about. Three things I'd want addressed before this lands, one of them structural.

Comment thread app/services/subscriptions/product_catalog/materialize_service.rb Outdated
Comment thread app/services/subscriptions/product_catalog/materialize_service.rb
Comment thread app/models/billing_segment.rb Outdated
Comment thread app/models/billing_segment.rb
tiagolupepic
tiagolupepic reviewed Sep 2, 2026
View reviewed changes
Comment thread app/models/billing_segment.rb Outdated
tiagolupepic
tiagolupepic reviewed Sep 2, 2026
View reviewed changes
Comment thread app/models/billing_segment.rb
annvelents
annvelents reviewed Sep 3, 2026
View reviewed changes
Comment thread db/migrate/20260901122946_create_billing_segments.rb Outdated
annvelents
annvelents reviewed Sep 3, 2026
View reviewed changes
Comment thread db/migrate/20260901122946_create_billing_segments.rb Outdated
annvelents
annvelents reviewed Sep 3, 2026
View reviewed changes
Comment thread app/models/billing_segment.rb
annvelents
annvelents reviewed Sep 3, 2026
View reviewed changes
Comment thread app/services/billing/calendar.rb Outdated
annvelents
annvelents reviewed Sep 3, 2026
View reviewed changes
Comment thread app/services/billing/calendar.rb Outdated
annvelents
annvelents reviewed Sep 3, 2026
View reviewed changes
Comment thread app/services/billing/segments.rb
annvelents
annvelents reviewed Sep 3, 2026
View reviewed changes
Comment thread spec/services/billing/rate_cards/build_schedule_service_spec.rb
annvelents
annvelents reviewed Sep 3, 2026
View reviewed changes
Comment thread app/services/billing/schedule.rb Outdated
annvelents
annvelents reviewed Sep 3, 2026
View reviewed changes
Comment thread app/services/billing/schedule.rb Outdated
annvelents
annvelents reviewed Sep 3, 2026
View reviewed changes
Comment thread app/services/billing/schedule.rb Outdated
annvelents
annvelents reviewed Sep 3, 2026
View reviewed changes
Comment thread app/services/billing/schedule.rb Outdated
annvelents
annvelents reviewed Sep 3, 2026
View reviewed changes
Comment thread app/services/billing/build_schedule_service.rb Outdated
annvelents
annvelents reviewed Sep 3, 2026
View reviewed changes
Comment thread app/services/billing/interval.rb
annvelents
annvelents reviewed Sep 3, 2026
View reviewed changes
Comment thread app/services/billing/build_schedule_service.rb Outdated
annvelents
annvelents reviewed Sep 4, 2026
View reviewed changes
Comment thread app/services/billing/calendar.rb Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiagolupepic tiagolupepic tiagolupepic left review comments
@annvelents annvelents annvelents left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brunomiguelpinto @tiagolupepic @annvelents