feat(events): filter billing segments - #6296
Draft
tiagolupepic wants to merge 2 commits into
Draft
Conversation
## Context Billing segment fee computation needs the billing period prefilter to work with product-catalog billing work items and product filters, while preserving the existing charge-backed path. ## Description Add a billing segment resolver and source adapter to the billing period filter service. Key segment-backed filter targets by product, support key-only product filter values in the shared matcher, and cover the new behavior with focused specs plus a charge filter regression.
## Context Charge and billing segment filter resolvers share the same raw event combination matching and target bucket merge logic. ## Description Add a base billing period filter resolver and move shared event matching behavior into it. Make the charge and billing segment resolvers inherit from the base class while keeping their target-specific behavior in each subclass.
tiagolupepic
commented
Sep 4, 2026
| def event_store | ||
| @event_store ||= Events::Stores::StoreFactory.new_instance( | ||
| organization:, | ||
| subscription: contract, |
Contributor
Author
There was a problem hiding this comment.
this is wrong and depends on this PR #6294
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Billing segment fee computation needs the billing period prefilter to work with product-catalog billing work items and product filters, while preserving the existing charge-backed path.
Description
Add a billing segment resolver and source adapter to the billing period filter service. Key segment-backed filter targets by product, support key-only product filter values in the shared matcher, and cover the new behavior with focused specs plus a charge filter regression.