Skip to content

feat(cache): Add redis cache url - #172

Merged
jdenquin merged 3 commits into
mainfrom
add-redis-cache-url
Aug 18, 2025
Merged

feat(cache): Add redis cache url#172
jdenquin merged 3 commits into
mainfrom
add-redis-cache-url

Conversation

@jdenquin

Copy link
Copy Markdown
Contributor

No description provided.

@jdenquin
jdenquin requested a review from Copilot August 18, 2025 09:57
@jdenquin jdenquin self-assigned this Aug 18, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new Redis cache URL configuration option to allow separate Redis instances for caching and other operations. The changes enable users to specify a dedicated Redis cache URL while maintaining backward compatibility by falling back to the existing Redis URL when the cache URL is not provided.

  • Adds redisCacheUrl configuration option to Helm chart values
  • Updates all deployment templates to reference the new Redis cache URL instead of the generic Redis URL
  • Implements fallback logic in secrets template to use the main Redis URL when cache URL is not specified

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

File Description
charts/lago/values.yaml Adds commented redisCacheUrl configuration option
charts/lago/templates/secrets.yaml Implements logic to generate redisCacheUrl secret with fallback to redisUrl
Multiple deployment templates Updates environment variable references from redisUrl to redisCacheUrl

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread charts/lago/templates/secrets.yaml Outdated
@jdenquin
jdenquin merged commit fe13c12 into main Aug 18, 2025
1 check passed
@jdenquin
jdenquin deleted the add-redis-cache-url branch August 18, 2025 13:20
@discostur

Copy link
Copy Markdown
Contributor

@jdenquin maybe you should mention this in the readme, too ... there is no reference to redisCacheUrl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants