feat(cache): Add redis cache url - #172
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new Redis cache URL configuration option to allow separate Redis instances for caching and other operations. The changes enable users to specify a dedicated Redis cache URL while maintaining backward compatibility by falling back to the existing Redis URL when the cache URL is not provided.
- Adds
redisCacheUrlconfiguration option to Helm chart values - Updates all deployment templates to reference the new Redis cache URL instead of the generic Redis URL
- Implements fallback logic in secrets template to use the main Redis URL when cache URL is not specified
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| charts/lago/values.yaml | Adds commented redisCacheUrl configuration option |
| charts/lago/templates/secrets.yaml | Implements logic to generate redisCacheUrl secret with fallback to redisUrl |
| Multiple deployment templates | Updates environment variable references from redisUrl to redisCacheUrl |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
rsempe
approved these changes
Aug 18, 2025
vincent-pochet
approved these changes
Aug 18, 2025
Contributor
|
@jdenquin maybe you should mention this in the readme, too ... there is no reference to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.