tp: assert that a column is of a given type - #7167
Draft
LalitMaganti wants to merge 1 commit into
Draft
Conversation
🎨 Perfetto UI Builds
|
LalitMaganti
force-pushed
the
dev/lalitm/exec-assert-column-type
branch
from
August 21, 2026 13:34
62f4dcd to
0ff9bcb
Compare
LalitMaganti
force-pushed
the
dev/lalitm/exec-assert-column-type
branch
from
August 21, 2026 13:43
0ff9bcb to
2f056ac
Compare
LalitMaganti
force-pushed
the
dev/lalitm/exec-assert-column-type
branch
from
August 21, 2026 13:53
2f056ac to
98d4d5e
Compare
LalitMaganti
force-pushed
the
dev/lalitm/exec-assert-column-type
branch
from
August 21, 2026 14:23
98d4d5e to
2298a36
Compare
LalitMaganti
force-pushed
the
dev/lalitm/exec-assert-column-type
branch
from
August 21, 2026 15:12
2298a36 to
a22a502
Compare
LalitMaganti
force-pushed
the
dev/lalitm/exec-assert-column-type
branch
from
August 21, 2026 15:21
a22a502 to
c6f181b
Compare
LalitMaganti
force-pushed
the
dev/lalitm/exec-assert-column-type
branch
from
August 21, 2026 15:33
c6f181b to
129d977
Compare
A column whose values carry their own type has to become a single type before anything typed can read it, and that claim needs checking rather than assuming. AssertType is where that happens. It checks every row against the type asked for and returns a flat column, widening a narrower integer where the conversion is exact and converting nothing else. It belongs here rather than in the source because a source cannot know what a column is for, and the operator which does is not the one reading it.
LalitMaganti
force-pushed
the
dev/lalitm/exec-assert-column-type
branch
from
August 21, 2026 16:18
129d977 to
0b6d57b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A column whose values carry their own type has to become a single type
before anything typed can read it, and that claim needs checking rather
than assuming.
AssertType is where that happens. It checks every row against the type
asked for and returns a flat column, widening a narrower integer where
the conversion is exact and converting nothing else.
It belongs here rather than in the source because a source cannot know
what a column is for, and the operator which does is not the one
reading it.