proto: change WindowManager child_tokens format - #7184
Open
rukkal wants to merge 1 commit into
Open
Conversation
🎨 Perfetto UI Builds
|
LalitMaganti
approved these changes
Aug 22, 2026
rukkal
force-pushed
the
dev/rukkal/wm-proto-change-children-field-type
branch
from
August 24, 2026 05:27
4c1fd44 to
5f85b36
Compare
This commit changes the WindowManager's child_tokens field from a repeated int32 to a repeated IdentifierProto message. Thus the WindowManager incremental tracing can signal to the ProtoVM when the list becomes empty, emitting an empty IndentifierProto message. This is a breaking change, but acceptable as the field is not being used yet. Bug: 512718675 Change-Id: I8b32b36ac3d691c5389a0b5a1174c7d2a82113f8
rukkal
force-pushed
the
dev/rukkal/wm-proto-change-children-field-type
branch
from
August 24, 2026 07:06
5f85b36 to
5cef632
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit changes the WindowManager's child_tokens field from a
repeated int32 to a repeated IdentifierProto message.
Thus the WindowManager incremental tracing can signal to the ProtoVM
when the list becomes empty, emitting an empty IndentifierProto message.
This is a breaking change, but acceptable as the field is not being used
yet.
Bug: 512718675