Skip to content

ui: Fix Day Explorer flamegraph root selection for selected tracks #7187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sanath099 wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −16
Open

ui: Fix Day Explorer flamegraph root selection for selected tracks #7187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 2 additions & 16 deletions ui/src/plugins/com.android.DayExplorer/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,31 +212,17 @@ export default class DayExplorerPlugin implements PerfettoPlugin {
),
descendants(track_id) AS (
SELECT track_id FROM selected_roots
UNION ALL
UNION
SELECT child.track_id
FROM day_explorer_ui_hierarchy child
JOIN descendants parent ON child.parent_id = parent.track_id
),
ancestors(track_id, parent_id) AS (
SELECT track_id, parent_id
FROM day_explorer_ui_hierarchy
WHERE track_id IN (SELECT track_id FROM selected_roots)
UNION ALL
SELECT parent.track_id, parent.parent_id
FROM day_explorer_ui_hierarchy parent
JOIN ancestors child ON child.parent_id = parent.track_id
),
all_nodes(track_id) AS (
SELECT track_id FROM descendants
UNION
SELECT track_id FROM ancestors
),
total_energy AS (
SELECT track_id, parent_id, display_name, SUM(energy_uws) AS energy_uws
FROM day_explorer_ui_hierarchy_per_ts
WHERE ts >= ${currentSelection.start}
AND ts <= ${currentSelection.end}
AND track_id IN (SELECT track_id FROM all_nodes)
AND track_id IN (SELECT track_id FROM descendants)
GROUP BY 1, 2, 3
),
with_child AS (
Expand Down