ui: remove redundant flamegraph highlight Hide button - #7199
Merged
Conversation
🎨 Perfetto UI Builds
|
LalitMaganti
force-pushed
the
dev/lalitm/flamegraph-remove-highlight-hide
branch
from
August 24, 2026 16:40
36d5019 to
6f6ce4f
Compare
stevegolton
approved these changes
Aug 25, 2026
The Highlight toggle already closes the controls while preserving an active highlight. Keeping a second Hide action in the expanded row duplicates that behavior and makes the control harder to scan.
LalitMaganti
force-pushed
the
dev/lalitm/flamegraph-remove-highlight-hide
branch
from
August 25, 2026 13:42
6f6ce4f to
c531bb1
Compare
LalitMaganti
enabled auto-merge (squash)
August 25, 2026 13:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Highlight toggle already closes the controls while preserving an active highlight. Keeping a second Hide action in the expanded row duplicates that behavior and makes the control harder to scan.