Forward attributes to broadcast_refresh_to and broadcast_refresh_later_to - #788
Open
carldaws wants to merge 1 commit into
Open
Forward attributes to broadcast_refresh_to and broadcast_refresh_later_to#788carldaws wants to merge 1 commit into
carldaws wants to merge 1 commit into
Conversation
carldaws
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#763 passes attributes from broadcast_refresh_to and broadcast_refresh_later_to to turbo_stream_refresh_tag but the model helpers which delegate to them (broadcast_refresh and broadcast_refresh_later) take no arguments.
The other broadcast methods (broadcast_replace, broadcast_append and so on) all accept attributes, so this change brings the refresh variants in line.