Skip to content

Added aspect ratio constraint - #22

Open
ghost wants to merge 17 commits into
jasekz:devfrom
SparkMakerspace:dev
Open

Added aspect ratio constraint#22
ghost wants to merge 17 commits into
jasekz:devfrom
SparkMakerspace:dev

Conversation

@ghost

@ghost ghost commented Mar 10, 2017

Copy link
Copy Markdown

This should merge properly, I think. Sorry about my last pull request.

@jasekz

jasekz commented Mar 10, 2017

Copy link
Copy Markdown
Owner

Can you explain what issue you were having and are attempting to fix? Also, I can't merge changes where you're changing the repo name, i.e - "name": "jjfs85/laradrop". If you'd like to do that, you should fork it instead.

@ghost

ghost commented Mar 10, 2017

Copy link
Copy Markdown
Author

My intended feature addition is a config parameter called thumb_aspect that is a boolean and when it is set to true, the thumbnail generation will maintain the original image's aspect ratio. I admit the the above set of commits look messy, but look at the file comparison between your present dev branch and my pull request, you'll see only two files have changes: the laradropController and the config.php. I've reverted your repo name and namespace changes.

@jasekz

jasekz commented Mar 13, 2017

Copy link
Copy Markdown
Owner

Ok, thanks. Cool feature, but would you be able to also implement the option to maintain the height? Just in case someone wants to maintain the height instead of width.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant