Skip to content

Check response status codes #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Art4 wants to merge 46 commits into
base: v2.x
Choose a base branch
from
Open

Check response status codes #465

Show file tree
Hide file tree
Changes from 39 commits
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
36d5d5e
feat: create Future class
Art4 Mar 10, 2026
967b977
feat: create Future::enableForwardCompatibility() method
Art4 Mar 10, 2026
9351bb8
feat: create Future::disableForwardCompatibility() method
Art4 Mar 10, 2026
1d89ab0
feat: implement enableFutureMode() in Client implementations
Art4 Mar 10, 2026
dd287a2
feat: check for correct response status code on create issue
Art4 Mar 10, 2026
c06b62b
feat: check for correct response status code on Attachment::upload()
Art4 Jul 26, 2026
fb7dbfc
feat: check for correct response status code on Attachment::remove()
Art4 Jul 26, 2026
93d7c12
feat: check for correct response status code on IssueCategory::create()
Art4 Jul 26, 2026
cd32963
feat: check for correct response status code on IssueCategory::update()
Art4 Jul 26, 2026
0c595c1
feat: check for correct response status code on IssueCategory::remove()
Art4 Jul 26, 2026
0ca530c
feat: check for correct response status code on Membership::create()
Art4 Jul 26, 2026
5bc2265
feat: check for correct response status code on Membership::update()
Art4 Jul 26, 2026
266a679
feat: check for correct response status code on Membership::remove()
Art4 Jul 26, 2026
b3f8ea2
feat: check for correct response status code on TimeEntry::create()
Art4 Jul 26, 2026
1d87d20
feat: check for correct response status code on TimeEntry::update()
Art4 Jul 26, 2026
e02ef15
feat: check for correct response status code on TimeEntry::remove()
Art4 Jul 26, 2026
e7a8594
feat: check for correct response status code on Version::create()
Art4 Jul 26, 2026
b12eb35
feat: check for correct response status code on Version::update()
Art4 Jul 26, 2026
a8b916f
feat: check for correct response status code on Version::remove()
Art4 Jul 26, 2026
85df940
feat: check for correct response status code on Group::create()
Art4 Jul 26, 2026
9a28ecb
feat: check for correct response status code on Group::update()
Art4 Jul 26, 2026
8ce91bb
feat: check for correct response status code on Group::remove()
Art4 Jul 26, 2026
da6eb44
feat: check for correct response status code on Group::addUser()
Art4 Jul 26, 2026
12be2de
feat: check for correct response status code on Group::removeUser()
Art4 Jul 26, 2026
f4aa6d2
feat: check for correct response status code on User::create()
Art4 Jul 26, 2026
3e17bf5
feat: check for correct response status code on User::update()
Art4 Jul 26, 2026
3377864
feat: check for correct response status code on User::remove()
Art4 Jul 26, 2026
40d9d97
feat: check for correct response status code on Project::create()
Art4 Jul 26, 2026
1e14c25
feat: check for correct response status code on Project::update()
Art4 Jul 26, 2026
c8710ca
feat: check for correct response status code on Project::remove()
Art4 Jul 26, 2026
59cd660
feat: check for correct response status code on IssueRelation::create()
Art4 Jul 26, 2026
2dbbda2
feat: check for correct response status code on IssueRelation::remove()
Art4 Jul 26, 2026
ee31f23
feat: check for correct response status code on Issue::update()
Art4 Jul 26, 2026
33877e7
feat: check for correct response status code on Issue::remove()
Art4 Jul 26, 2026
cf51454
feat: check for correct response status code on Issue::addWatcher()
Art4 Jul 26, 2026
42bb0fe
feat: check for correct response status code on Issue::removeWatcher()
Art4 Jul 26, 2026
26f14c0
feat: check for correct response status code on Issue::attachMany()
Art4 Jul 26, 2026
87faab7
feat: check for correct response status code on Wiki::create()
Art4 Jul 26, 2026
48f500e
feat: check for correct response status code on Wiki::remove()
Art4 Jul 26, 2026
5f68c45
fix: correct BC guard in Issue::create(), IssueCategory::create(), Me…
Art4 Jul 26, 2026
044cb8a
docs: add enableFutureMode() documentation, update changelog, remove …
Art4 Jul 26, 2026
298d432
test: use non-empty response body in incorrect-status tests for remov…
Art4 Jul 26, 2026
c4ce4ac
test: wrap enableFutureMode tests in try/finally to always restore gl…
Art4 Jul 26, 2026
9b4b876
test: add non-empty body BC tests for create methods, fix FutureTest …
Art4 Jul 26, 2026
7c2012a
feat: return SimpleXMLElement from BC guard when body is non-empty XML
Art4 Jul 26, 2026
fe7faca
test: add non-empty body BC coverage for Group::addUser and Issue::ad…
Art4 Jul 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 24 additions & 2 deletions src/Redmine/Api/Attachment.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
use Redmine\Client\Client;
use Redmine\Exception\SerializerException;
use Redmine\Exception\UnexpectedResponseException;
use Redmine\Future;
use Redmine\Http\HttpClient;
use Redmine\Http\HttpFactory;
use Redmine\Serializer\JsonSerializer;
Expand Down Expand Up @@ -156,7 +157,17 @@ public function upload($attachment, $params = [])
$attachment,
));

return $this->lastResponse->getContent();
$body = $this->lastResponse->getContent();

if ($this->lastResponse->getStatusCode() !== 201) {
if (!Future::isForwardCompatibilityEnabled()) {
return $body;
}

throw UnexpectedResponseException::create($this->lastResponse);
}

return $body;
}

/**
Expand All @@ -175,6 +186,17 @@ public function remove($id)
'/attachments/' . urlencode(strval($id)) . '.xml',
));

return $this->lastResponse->getContent();
$body = $this->lastResponse->getContent();
$statusCode = $this->lastResponse->getStatusCode();

if ($statusCode !== 200 && $statusCode !== 204) {
if (!Future::isForwardCompatibilityEnabled()) {
return $body;
}

throw UnexpectedResponseException::create($this->lastResponse);
}

return $body;
}
}
58 changes: 55 additions & 3 deletions src/Redmine/Api/Group.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
use Redmine\Exception\MissingParameterException;
use Redmine\Exception\SerializerException;
use Redmine\Exception\UnexpectedResponseException;
use Redmine\Future;
use Redmine\Http\HttpClient;
use Redmine\Http\HttpFactory;
use Redmine\Serializer\JsonSerializer;
Expand Down Expand Up @@ -195,6 +196,15 @@ public function create(array $params = [])
));

$body = $this->lastResponse->getContent();
$statusCode = $this->lastResponse->getStatusCode();

if ($statusCode !== 201) {
if (!Future::isForwardCompatibilityEnabled()) {
return $body;
}

throw UnexpectedResponseException::create($this->lastResponse);
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.

if ($body === '') {
return $body;
Expand Down Expand Up @@ -229,7 +239,18 @@ public function update(int $id, array $params = [])
XmlSerializer::createFromArray(['group' => $params])->getEncoded(),
));

return $this->lastResponse->getContent();
$body = $this->lastResponse->getContent();
$statusCode = $this->lastResponse->getStatusCode();

if ($statusCode !== 200 && $statusCode !== 204) {
if (!Future::isForwardCompatibilityEnabled()) {
return $body;
}

throw UnexpectedResponseException::create($this->lastResponse);
}

return $body;
}

/**
Expand Down Expand Up @@ -280,7 +301,18 @@ public function remove($id)
'/groups/' . strval($id) . '.xml',
));

return $this->lastResponse->getContent();
$body = $this->lastResponse->getContent();
$statusCode = $this->lastResponse->getStatusCode();

if ($statusCode !== 200 && $statusCode !== 204) {
if (!Future::isForwardCompatibilityEnabled()) {
return $body;
}

throw UnexpectedResponseException::create($this->lastResponse);
}

return $body;
}

/**
Expand All @@ -302,6 +334,15 @@ public function addUser($id, $userId)
));

$body = $this->lastResponse->getContent();
$statusCode = $this->lastResponse->getStatusCode();

if ($statusCode !== 201) {
if (!Future::isForwardCompatibilityEnabled()) {
return $body;
}

throw UnexpectedResponseException::create($this->lastResponse);
}

if ($body === '') {
return $body;
Expand All @@ -327,6 +368,17 @@ public function removeUser($id, $userId)
'/groups/' . strval($id) . '/users/' . strval($userId) . '.xml',
));

return $this->lastResponse->getContent();
$body = $this->lastResponse->getContent();
$statusCode = $this->lastResponse->getStatusCode();

if ($statusCode !== 200 && $statusCode !== 204) {
if (!Future::isForwardCompatibilityEnabled()) {
return $body;
}

throw UnexpectedResponseException::create($this->lastResponse);
}

return $body;
}
}
70 changes: 64 additions & 6 deletions src/Redmine/Api/Issue.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
use Redmine\Exception;
use Redmine\Exception\SerializerException;
use Redmine\Exception\UnexpectedResponseException;
use Redmine\Future;
use Redmine\Http\HttpClient;
use Redmine\Http\HttpFactory;
use Redmine\Serializer\JsonSerializer;
Expand Down Expand Up @@ -256,8 +257,12 @@ public function create(array $params = [])

$body = $this->lastResponse->getContent();

if ($body === '') {
return $body;
if ($this->lastResponse->getStatusCode() !== 201) {
if (!Future::isForwardCompatibilityEnabled() && $body === '') {
return $body;
}

throw UnexpectedResponseException::create($this->lastResponse);
}

return new SimpleXMLElement($body);
Expand Down Expand Up @@ -306,7 +311,18 @@ public function update($id, array $params)
XmlSerializer::createFromArray(['issue' => $sanitizedParams])->getEncoded(),
));

return $this->lastResponse->getContent();
$body = $this->lastResponse->getContent();
$statusCode = $this->lastResponse->getStatusCode();

if ($statusCode !== 200 && $statusCode !== 204) {
if (!Future::isForwardCompatibilityEnabled()) {
return $body;
}

throw UnexpectedResponseException::create($this->lastResponse);
}

return $body;
}

/**
Expand All @@ -324,6 +340,15 @@ public function addWatcher($id, $watcherUserId)
));

$body = $this->lastResponse->getContent();
$statusCode = $this->lastResponse->getStatusCode();

if ($statusCode !== 201) {
if (!Future::isForwardCompatibilityEnabled()) {
return $body;
}

throw UnexpectedResponseException::create($this->lastResponse);
}

if ($body === '') {
return $body;
Expand All @@ -345,7 +370,18 @@ public function removeWatcher($id, $watcherUserId)
'/issues/' . urlencode(strval($id)) . '/watchers/' . urlencode(strval($watcherUserId)) . '.xml',
));

return $this->lastResponse->getContent();
$body = $this->lastResponse->getContent();
$statusCode = $this->lastResponse->getStatusCode();

if ($statusCode !== 200 && $statusCode !== 204) {
if (!Future::isForwardCompatibilityEnabled()) {
return $body;
}

throw UnexpectedResponseException::create($this->lastResponse);
}

return $body;
}

/**
Expand Down Expand Up @@ -498,7 +534,18 @@ public function attachMany($id, array $attachments)
JsonSerializer::createFromArray(['issue' => $params])->getEncoded(),
));

return $this->lastResponse->getContent();
$body = $this->lastResponse->getContent();
$statusCode = $this->lastResponse->getStatusCode();

if ($statusCode !== 200 && $statusCode !== 201 && $statusCode !== 204) {
if (!Future::isForwardCompatibilityEnabled()) {
return $body;
}

throw UnexpectedResponseException::create($this->lastResponse);
}

return $body;
}

/**
Expand All @@ -515,7 +562,18 @@ public function remove($id)
'/issues/' . urlencode(strval($id)) . '.xml',
));

return $this->lastResponse->getContent();
$body = $this->lastResponse->getContent();
$statusCode = $this->lastResponse->getStatusCode();

if ($statusCode !== 200 && $statusCode !== 204) {
if (!Future::isForwardCompatibilityEnabled()) {
return $body;
}

throw UnexpectedResponseException::create($this->lastResponse);
}

return $body;
}

/**
Expand Down
35 changes: 33 additions & 2 deletions src/Redmine/Api/IssueCategory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
use Redmine\Exception\MissingParameterException;
use Redmine\Exception\SerializerException;
use Redmine\Exception\UnexpectedResponseException;
use Redmine\Future;
use Redmine\Http\HttpClient;
use Redmine\Http\HttpFactory;
use Redmine\Serializer\JsonSerializer;
Expand Down Expand Up @@ -267,6 +268,14 @@ public function create($project, array $params = [])

$body = $this->lastResponse->getContent();

if ($this->lastResponse->getStatusCode() !== 201) {
if (!Future::isForwardCompatibilityEnabled() && $body === '') {
return $body;
}

throw UnexpectedResponseException::create($this->lastResponse);
}

Comment thread
coderabbitai[bot] marked this conversation as resolved.
if ($body === '') {
return $body;
}
Expand Down Expand Up @@ -298,7 +307,18 @@ public function update($id, array $params)
XmlSerializer::createFromArray(['issue_category' => $params])->getEncoded(),
));

return $this->lastResponse->getContent();
$body = $this->lastResponse->getContent();
$statusCode = $this->lastResponse->getStatusCode();

if ($statusCode !== 200 && $statusCode !== 204) {
if (!Future::isForwardCompatibilityEnabled()) {
return $body;
}

throw UnexpectedResponseException::create($this->lastResponse);
}

return $body;
}

/**
Expand All @@ -320,7 +340,18 @@ public function remove($id, array $params = [])
PathSerializer::create('/issue_categories/' . urlencode(strval($id)) . '.xml', $params)->getPath(),
));

return $this->lastResponse->getContent();
$body = $this->lastResponse->getContent();
$statusCode = $this->lastResponse->getStatusCode();

if ($statusCode !== 200 && $statusCode !== 204) {
if (!Future::isForwardCompatibilityEnabled()) {
return $body;
}

throw UnexpectedResponseException::create($this->lastResponse);
}

return $body;
}

/**
Expand Down
23 changes: 22 additions & 1 deletion src/Redmine/Api/IssueRelation.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
use Redmine\Exception\MissingParameterException;
use Redmine\Exception\SerializerException;
use Redmine\Exception\UnexpectedResponseException;
use Redmine\Future;
use Redmine\Http\HttpClient;
use Redmine\Http\HttpFactory;
use Redmine\Serializer\JsonSerializer;
Expand Down Expand Up @@ -159,7 +160,18 @@ public function remove($id)
'/relations/' . $id . '.xml',
));

return $this->lastResponse->getContent();
$body = $this->lastResponse->getContent();
$statusCode = $this->lastResponse->getStatusCode();

if ($statusCode !== 200 && $statusCode !== 204) {
if (!Future::isForwardCompatibilityEnabled()) {
return $body;
}

throw UnexpectedResponseException::create($this->lastResponse);
}

return $body;
}

/**
Expand Down Expand Up @@ -200,6 +212,15 @@ public function create($issueId, array $params = [])
));

$body = $this->lastResponse->getContent();
$statusCode = $this->lastResponse->getStatusCode();

if ($statusCode !== 201) {
if (!Future::isForwardCompatibilityEnabled()) {
return JsonSerializer::createFromString($body)->getNormalized();
}

throw UnexpectedResponseException::create($this->lastResponse);
}

return JsonSerializer::createFromString($body)->getNormalized();
}
Expand Down
Loading
Loading