fix(python): reject whitespace-only values in env_utils - #1318
Open
Zain Shahbaz (zainshahbaz786) wants to merge 1 commit into
Open
fix(python): reject whitespace-only values in env_utils#1318Zain Shahbaz (zainshahbaz786) wants to merge 1 commit into
Zain Shahbaz (zainshahbaz786) wants to merge 1 commit into
Conversation
Treat blank or whitespace-only environment variables as missing in get_required_env and validate_env_vars, and add pytest coverage.
Contributor
|
👋 Thanks for contributing Zain Shahbaz (@zainshahbaz786)! We will review the pull request and get back to you soon. |
Author
|
Hi John (John Aziz (@john0isaac)), |
Contributor
|
Zain Shahbaz (@zainshahbaz786) thanks for flagging, checking and fixing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Treat blank or whitespace-only environment variables as missing in get_required_env and validate_env_vars, and add pytest coverage.