Update buoy and planter as per fix to reservoir leaks along edges - #82
Open
capsulecorplab wants to merge 8 commits into
Open
Update buoy and planter as per fix to reservoir leaks along edges#82capsulecorplab wants to merge 8 commits into
capsulecorplab wants to merge 8 commits into
Conversation
capsulecorplab
force-pushed
the
update-buoy-and-planter-as-per-fix-to-reservoir-leaks-along-edges
branch
from
March 14, 2026 23:46
da9456f to
d8c80b8
Compare
capsulecorplab
marked this pull request as ready for review
March 14, 2026 23:46
… leaks - uses hexagon2d helper function - replaces circular bottom fillet with straight fillets along edges
capsulecorplab
force-pushed
the
update-buoy-and-planter-as-per-fix-to-reservoir-leaks-along-edges
branch
from
March 15, 2026 01:07
d8c80b8 to
a4a110b
Compare
Collaborator
Author
|
Need to round out corners along keyhole cutout on buoy |
as to provide less sharp overhangs along corners of bottom fillet of keyhole
Collaborator
Author
|
Leaks still persist along sharp corners of bottom filleted edges as of 439a339 |
…sharp corners on bottom fillet - refactors fillet steps used in fillet function calls into fillet_steps variable - sets all fillet radiuses to global, r_fillet, variable
Collaborator
Author
|
Leaks still persist as of 63f79d9 |
…let for reducing sharp edges implements bottom fillet along keyhole and wall edges using bottom fillet applied to linear extrusion of rounded equilateral triangle
Collaborator
Author
|
No leaks for half scale model as of 115ad93 |
Collaborator
Author
|
Leaks still persist on 0.75x scale buoy after 2 months of testing. Exact point of leak TBD |
capsulecorplab
force-pushed
the
update-buoy-and-planter-as-per-fix-to-reservoir-leaks-along-edges
branch
from
May 27, 2026 23:20
16ece84 to
d7a67f9
Compare
…hole walls - reduces bottom fillet radius by 25% - creates wedge-shaped filleted cavity bet drain pipe and keyhole walls in attempt to round out sharp corners
capsulecorplab
force-pushed
the
update-buoy-and-planter-as-per-fix-to-reservoir-leaks-along-edges
branch
from
May 28, 2026 01:29
d7a67f9 to
f1f6126
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #81