17 multi type value test - #22
Open
hulkoba wants to merge 11 commits into
Open
Conversation
hulkoba
commented
Nov 19, 2025
Comment on lines
-53
to
-69
| class MultiValueFieldJSONTests(mango.DbPerClass, MultiValueFieldTests): | ||
| def setUp(self): | ||
| super().setUp(db_per_test=True) | ||
| self.db.save_docs(copy.deepcopy(DOCS)) | ||
| self.db.create_index(["name"]) | ||
| self.db.create_index(["age", "name"]) | ||
|
|
||
|
|
||
| # @unittest.skipUnless(mango.has_text_service(), "requires text service") | ||
| # class MultiValueFieldTextTests(MultiValueFieldDocsNoIndexes, OperatorTests): | ||
| # pass | ||
|
|
||
|
|
||
| class MultiValueFieldAllDocsTests(mango.DbPerClass, MultiValueFieldTests): | ||
| def setUp(self): | ||
| super().setUp(db_per_test=True) | ||
| self.db.save_docs(copy.deepcopy(DOCS)) |
Author
There was a problem hiding this comment.
I have not ported these, since there are no tests?
There was a problem hiding this comment.
Maybe they are executing the whole class (MultiValueFieldTests) with a different setup? After all MultiValueFieldTests is being passed on as a parameter
Member
There was a problem hiding this comment.
updated the test to use macro to run both MultiValueFieldJSONTests and MultiValueFieldAllDocsTests
68ab391
keeping the commit separate for now, for ease of review
hulkoba
force-pushed
the
port-python-tests
branch
5 times, most recently
from
November 19, 2025 14:21
c413a13 to
25f1f55
Compare
hulkoba
force-pushed
the
17-multi-type-value-test
branch
from
November 24, 2025 09:46
0664c40 to
427a28c
Compare
hulkoba
added
needs change
ready for review
and removed
ready for review
needs change
labels
…m Python to Elixir
Running the search tests with Clouseau 3.0 amplified the flakiness for containers which is making hard to use the CI -- disable those for now until they root cause is investigated and a fix is provided. Mind that native builds, e.g. FreeBSD and Windows are still there to catch Search-related regressions.
hulkoba
force-pushed
the
17-multi-type-value-test
branch
from
December 3, 2025 07:51
68ab391 to
df6e341
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR ports 17-multi-type-value-tests from python to elixir
Testing recommendations
Run:
Related Issues or Pull Requests
Checklist
rel/overlay/etc/default.inisrc/docsfolder