21 empty selector tests - #28
Open
hulkoba wants to merge 11 commits into
Open
Conversation
hulkoba
force-pushed
the
21-empty-selector-tests
branch
from
November 19, 2025 11:06
05f5478 to
c476253
Compare
hulkoba
marked this pull request as ready for review
November 19, 2025 11:06
hulkoba
force-pushed
the
21-empty-selector-tests
branch
from
November 19, 2025 11:09
c476253 to
a618917
Compare
hulkoba
force-pushed
the
port-python-tests
branch
from
November 19, 2025 11:15
a6a4cd5 to
3535602
Compare
hulkoba
force-pushed
the
21-empty-selector-tests
branch
from
November 19, 2025 11:25
a618917 to
08f3b9b
Compare
hulkoba
force-pushed
the
port-python-tests
branch
4 times, most recently
from
November 19, 2025 14:21
c413a13 to
25f1f55
Compare
hulkoba
force-pushed
the
21-empty-selector-tests
branch
from
November 24, 2025 09:43
08f3b9b to
022eb39
Compare
| assert resp["index"]["type"] == unquote(index_type) | ||
|
|
||
| {:ok, docs} = MangoDatabase.find(unquote(db), selector) | ||
| assert length(docs) == 0 |
Member
There was a problem hiding this comment.
Suggested change
| assert length(docs) == 0 | |
| assert Enum.empty?(docs) |
| assert resp["index"]["type"] == unquote(index_type) | ||
|
|
||
| {:ok, docs} = MangoDatabase.find(unquote(db), selector) | ||
| assert length(docs) == 0 |
Member
There was a problem hiding this comment.
Suggested change
| assert length(docs) == 0 | |
| assert Enum.empty?(docs) |
| assert resp["index"]["type"] == unquote(index_type) | ||
|
|
||
| {:ok, docs} = MangoDatabase.find(unquote(db), selector) | ||
| assert length(docs) == 0 |
Member
There was a problem hiding this comment.
Suggested change
| assert length(docs) == 0 | |
| assert Enum.empty?(docs) |
| assert resp["index"]["type"] == unquote(index_type) | ||
|
|
||
| {:ok, docs} = MangoDatabase.find(unquote(db), selector) | ||
| assert length(docs) == 0 |
Member
There was a problem hiding this comment.
Suggested change
| assert length(docs) == 0 | |
| assert Enum.empty?(docs) |
| assert resp["index"]["type"] == unquote(index_type) | ||
|
|
||
| {:ok, docs} = MangoDatabase.find(unquote(db), %{"$or" => []}) | ||
| assert length(docs) == 0 |
Member
There was a problem hiding this comment.
Suggested change
| assert length(docs) == 0 | |
| assert Enum.empty?(docs) |
Member
|
good from me ✔️ |
hulkoba
force-pushed
the
21-empty-selector-tests
branch
from
November 25, 2025 08:28
022eb39 to
4f2ade3
Compare
hulkoba
added
ready for review
ready to open at couchdb
opened on couchdb
and removed
needs change
ready for review
ready to open at couchdb
labels
…m Python to Elixir
Running the search tests with Clouseau 3.0 amplified the flakiness for containers which is making hard to use the CI -- disable those for now until they root cause is investigated and a fix is provided. Mind that native builds, e.g. FreeBSD and Windows are still there to catch Search-related regressions.
hulkoba
force-pushed
the
21-empty-selector-tests
branch
from
December 3, 2025 07:58
4f2ade3 to
ba96200
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR ports 21-empty-selector-tests from python to elixir
Testing recommendations
Run:
make elixiror
make elixir tests=test/elixir/test/mango/21_empty_selector_tests.exsand
make elixir-search tests=test/elixir/test/mango/21_empty_selector_tests.exsRelated Issues or Pull Requests
Checklist
rel/overlay/etc/default.inisrc/docsfolder