Update lint - #20732
Open
seanbudd wants to merge 13 commits into
Open
Conversation
uv run ruff check --fix
uv run ruff check --add-noqa
uv run ruff format
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates NVDA’s lint toolchain and applies broad, lint-driven mechanical edits across the codebase (typing modernizations, import handling, and style cleanups), plus a changelog note for the dependency bumps.
Changes:
- Bump lint tooling versions (ruff/prek/pyright/ty) and adjust Ruff configuration (including treating import sorting as an unsafe fix).
- Apply repo-wide lint cleanups (type annotation updates,
super()simplifications, exception modernizations, and targetednoqaadditions). - Update
user_docs/en/changes.mdwith the dependency updates and remove the dedicated Actionlint config file.
Reviewed changes
Copilot reviewed 298 out of 649 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Updates lint tool versions and Ruff config; adds/adjusts lint ignores and unsafe-fix settings. |
| user_docs/en/changes.md | Documents updated developer-facing dependencies. |
| source/UIAHandler/_remoteOps/remoteTypes/extensionTarget.py | Updates typing for remote extension calls (but currently introduces a type mismatch). |
| source/controlTypes/init.py | Lint-driven import/noqa adjustments around re-exports. |
| source/objbase.py | Lint-driven import adjustments (currently introduces a wildcard-import lint issue). |
| source/brailleTables/init.py | Lint-driven import adjustments (currently reintroduces E402/F401 concerns). |
| runtime-builders/synthDriverHost32/setup-runtime.py | Lint-driven import/noqa adjustments in runtime build script (currently missing E402 suppressions). |
| runtime-builders/synthDriverHost32/buildVersionLoader.py | Lint-driven import/noqa adjustments (currently missing E402 suppression). |
| source/_synthDrivers32/sapi5.py | Lint-driven import/noqa adjustments (currently missing E402 suppressions). |
| nvdaHelper/ia2_sconscript | Lint-driven updates; builder still leaves files unclosed (suppressed rather than fixed). |
| .github/actionlint.yml | Removed Actionlint configuration override. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None
Summary of the issue:
Our linting is out of date
Description of user facing changes:
None
Description of developer facing changes:
Updates lint tooling
Description of development approach:
Update pyproject.toml and similar config files
Run formatting tools (refer to commit messages)
manual cleanup
Testing strategy:
ci/cd
Known issues with pull request:
none
Code Review Checklist: