Skip to content

Update lint - #20732

Open
seanbudd wants to merge 13 commits into
masterfrom
updateLint
Open

Update lint#20732
seanbudd wants to merge 13 commits into
masterfrom
updateLint

Conversation

@seanbudd

Copy link
Copy Markdown
Member

Link to issue number:

None

Summary of the issue:

Our linting is out of date

Description of user facing changes:

None

Description of developer facing changes:

Updates lint tooling

Description of development approach:

  1. Update pyproject.toml and similar config files

    • move to maintained fork of action lint: rhysd (the author) inactive. Any active forks? rhysd/actionlint#719
      • allows us to delete lint rule suppressing issues with parallel jobs
    • update lint group
    • update ruff rules:
      • ensure import sorting is treated as an unsafe fix, as it is unsafe. this will require us to use noqa comments. the alternative is to ignore import sorting all together
      • ignore their warnings about module names that involve capital letters
  2. Run formatting tools (refer to commit messages)

  3. manual cleanup

Testing strategy:

ci/cd

Known issues with pull request:

none

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@seanbudd
seanbudd marked this pull request as ready for review August 25, 2026 04:22
@seanbudd
seanbudd requested a review from a team as a code owner August 25, 2026 04:22
@seanbudd
seanbudd requested review from SaschaCowley and a lite review from Copilot August 25, 2026 04:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates NVDA’s lint toolchain and applies broad, lint-driven mechanical edits across the codebase (typing modernizations, import handling, and style cleanups), plus a changelog note for the dependency bumps.

Changes:

  • Bump lint tooling versions (ruff/prek/pyright/ty) and adjust Ruff configuration (including treating import sorting as an unsafe fix).
  • Apply repo-wide lint cleanups (type annotation updates, super() simplifications, exception modernizations, and targeted noqa additions).
  • Update user_docs/en/changes.md with the dependency updates and remove the dedicated Actionlint config file.

Reviewed changes

Copilot reviewed 298 out of 649 changed files in this pull request and generated 10 comments.

Show a summary per file
File Description
pyproject.toml Updates lint tool versions and Ruff config; adds/adjusts lint ignores and unsafe-fix settings.
user_docs/en/changes.md Documents updated developer-facing dependencies.
source/UIAHandler/_remoteOps/remoteTypes/extensionTarget.py Updates typing for remote extension calls (but currently introduces a type mismatch).
source/controlTypes/init.py Lint-driven import/noqa adjustments around re-exports.
source/objbase.py Lint-driven import adjustments (currently introduces a wildcard-import lint issue).
source/brailleTables/init.py Lint-driven import adjustments (currently reintroduces E402/F401 concerns).
runtime-builders/synthDriverHost32/setup-runtime.py Lint-driven import/noqa adjustments in runtime build script (currently missing E402 suppressions).
runtime-builders/synthDriverHost32/buildVersionLoader.py Lint-driven import/noqa adjustments (currently missing E402 suppression).
source/_synthDrivers32/sapi5.py Lint-driven import/noqa adjustments (currently missing E402 suppressions).
nvdaHelper/ia2_sconscript Lint-driven updates; builder still leaves files unclosed (suppressed rather than fixed).
.github/actionlint.yml Removed Actionlint configuration override.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread pyproject.toml Outdated
Comment thread source/objbase.py
Comment thread source/controlTypes/__init__.py
Comment thread runtime-builders/synthDriverHost32/setup-runtime.py
Comment thread runtime-builders/synthDriverHost32/buildVersionLoader.py
Comment thread source/brailleTables/__init__.py
Comment thread runtime-builders/synthDriverHost32/setup-runtime.py
Comment thread source/UIAHandler/_remoteOps/remoteTypes/extensionTarget.py
Comment thread nvdaHelper/ia2_sconscript
Comment thread source/_synthDrivers32/sapi5.py
seanbudd and others added 3 commits August 25, 2026 14:34
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants