sapi: Remove unused SAPI methods which are in default SAPI properties - #23525
Open
NattyNarwhal wants to merge 3 commits into
Open
sapi: Remove unused SAPI methods which are in default SAPI properties#23525NattyNarwhal wants to merge 3 commits into
NattyNarwhal wants to merge 3 commits into
Conversation
NattyNarwhal
force-pushed
the
remove-force-http-10
branch
from
August 31, 2026 22:18
3befa6a to
7e332f0
Compare
NattyNarwhal
changed the title
Girgias
approved these changes
Sep 1, 2026
Girgias
left a comment
Girgias
left a comment
Member
There was a problem hiding this comment.
I agree although we may want to wait for this after 8.6 is branched as this touches a SAPI struct from what I understand?
| 5. SAPI changes | ||
| ======================== | ||
|
|
||
| - The force_http_10 method has been removed. |
Member
There was a problem hiding this comment.
I think indicating the change of the struct is also important
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
get_fd,force_http_10,get_target_uid, andget_target_gid.