Skip to content

This closes #2344, fixes CalcCellValue function returning incorrect calculation result when error values inside parentheses or operators - #2346

Merged
xuri merged 5 commits into
qax-os:masterfrom
huijian3139:master
Jul 6, 2026
Merged

This closes #2344, fixes CalcCellValue function returning incorrect calculation result when error values inside parentheses or operators#2346
xuri merged 5 commits into
qax-os:masterfrom
huijian3139:master

Conversation

@huijian3139

Copy link
Copy Markdown
Contributor
  • Update documentation for the PivotTableField data type
  • Update unit tests
  • Update GitHub Action packages version

PR Details

Description

Related Issue

Motivation and Context

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…rect calculation result when error values inside parentheses or operators

- Update documentation for the PivotTableField data type
- Update unit tests
- Update GitHub Action packages version
@codecov

codecov Bot commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.62%. Comparing base (09f0656) to head (a679cc1).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2346   +/-   ##
=======================================
  Coverage   99.61%   99.62%           
=======================================
  Files          32       32           
  Lines       26958    26961    +3     
=======================================
+ Hits        26854    26859    +5     
+ Misses         54       53    -1     
+ Partials       50       49    -1     
Flag Coverage Δ
unittests 99.62% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xuri xuri added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 30, 2026
@xuri xuri moved this to BugFix in Excelize v2.11.0 Jun 30, 2026
@xuri xuri linked an issue Jun 30, 2026 that may be closed by this pull request
2 tasks

@xuri xuri left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

@xuri
xuri merged commit 90ff348 into qax-os:master Jul 6, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

No open projects
Status: BugFix

Development

Successfully merging this pull request may close these issues.

CalcCellValue: error values inside parentheses or operators escape IFERROR

2 participants