Related to #1164: fix errors pushed as extra func arguments

[Aprax14]

PR Details

Fix calculation error propagation in function argument expressions

Description

This fixes incorrect error propagation in prepareEvalInfixExp when an arithmetic error (e.g. #DIV/0!) occurs while evaluating an expression inside a function argument.
Previously, when calculate() returned an error, the error was pushed to argsStack (the function's argument list) instead of opfdStack (the operand stack of the current expression). This caused each failed operation to be counted as an additional argument of the enclosing function. For example, IF(C1=0,0,A1/C1+B1/C1) with C1=0 would fail with "IF accepts at most 3 arguments".

Related Issue

Related to recent PR #2348 and also related to #2344

Motivation and Context

Formulas like =IF(C1=0,0,A1/C1+B1/C1) would fail while still being a valid excel formula.

How Has This Been Tested

Added unit test

Types of changes

• Docs change / refactoring / dependency upgrade
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.62%. Comparing base (1a6d13b) to head (fd33ea8).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2350   +/-   ##
=======================================
  Coverage   99.62%   99.62%           
=======================================
  Files          32       32           
  Lines       26969    26971    +2     
=======================================
+ Hits        26867    26869    +2     
  Misses         53       53           
  Partials       49       49           

Flag	Coverage Δ
unittests	99.62% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[xuri]

Thanks for your great work! I've made some changes based on your code branch.