Skip to content

This closes #2349, fix CalcCellVaue function does not return the expected error - #2354

Merged
xuri merged 1 commit into
qax-os:masterfrom
xixixi1118:master
Jul 20, 2026
Merged

This closes #2349, fix CalcCellVaue function does not return the expected error#2354
xuri merged 1 commit into
qax-os:masterfrom
xixixi1118:master

Conversation

@xixixi1118

Copy link
Copy Markdown
Contributor

PR Details

This closes #2349, fix CalcCellVaue function does not return the expected error

Description

This closes #2349, fix CalcCellVaue function does not return the expected error

Related Issue

#2349

Motivation and Context

#2349

How Has This Been Tested

update unit test

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@xuri xuri added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 20, 2026
@xuri xuri added this to v2.11.1 Jul 20, 2026
@xuri xuri moved this to Bugfix in v2.11.1 Jul 20, 2026
@codecov

codecov Bot commented Jul 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.62%. Comparing base (4953115) to head (6cde03f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2354      +/-   ##
==========================================
- Coverage   99.62%   99.62%   -0.01%     
==========================================
  Files          32       32              
  Lines       26971    26964       -7     
==========================================
- Hits        26869    26862       -7     
  Misses         53       53              
  Partials       49       49              
Flag Coverage Δ
unittests 99.62% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xuri xuri left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

@xuri
xuri merged commit 32931c3 into qax-os:master Jul 20, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

Status: Bugfix

Development

Successfully merging this pull request may close these issues.

CalcCellValue doesn't reproduce #VALUE! error

2 participants