Fix a memory leak in LStream. - #22400
Open
ppedrot wants to merge 2 commits into
Open
Conversation
… it. We introduce a new opaque type representing abstract positions in a stream, only introduced through the "current" position.
We don't store the locations in a hash table that never reclaims them. Instead, we thread them along the stream. The code unfortunately adds one more small stream implementation, but this is needed to overcome the limitations of the irremediably imperative API of stream.ml.
ppedrot
added
kind: cleanup
coqbot-app
Bot
removed
the
request: full CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We stop storing all stream locations from the past in a global hash table and rely instead on an explicit type pointing to specific positions of the stream.