Correctly validate block tags in rocqchk demarshaller. - #22408
Open
ppedrot wants to merge 1 commit into
Open
Conversation
Contrarily to the recommended fix in the report, we rely on the OCaml Obj API that exposes bounds on the valid block tags. Fixes rocq-prover#22407: rocqchk admits no-scan-tag blocks into validated .vo values.
ppedrot
added
kind: fix
coqbot-app
Bot
removed
the
request: full CI
Member
Author
|
I don't think this deserves a critical entry, handcrafted vo files are in my opinion outside of our attacker model. |
Member
I think we should consider hand-crafted .vo files as part of the attacker model for rocqchk but not rocqc. Or else we should have a rocqchk safe variant that is supposed to be robust against hand-crafted .vo files |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contrarily to the recommended fix in the report, we rely on the OCaml Obj API that exposes bounds on the valid block tags.
Fixes #22407: rocqchk admits no-scan-tag blocks into validated .vo values.