Skip to content

Add a proper dummy constr, instead of using mkProp - #22410

Open
yannl35133 wants to merge 1 commit into
rocq-prover:masterfrom
Yann-Leray:dummy-term
Open

Add a proper dummy constr, instead of using mkProp#22410
yannl35133 wants to merge 1 commit into
rocq-prover:masterfrom
Yann-Leray:dummy-term

Conversation

@yannl35133

Copy link
Copy Markdown
Contributor

I was tired of seeing mkProp used transparently as a dummy.
I replaced all uses of it with dummy, then went and checked whether these were dummies or actual uses of Prop.
I am pretty sure for all uses, but this warrants a second opinion.

I'm also not too sure about

let c = EConstr.mkProp in

which, if a dummy, hides it very deep, and
let tP = mkLetIn (idA, rdx_ty, tA, mkLetIn (anonR, mkProp, mkType Univ.Universe.type1, tP)) in

which may just need a substitution instead of an apparently useless let-in.

@yannl35133
yannl35133 requested review from a team as code owners August 27, 2026 14:44
@yannl35133 yannl35133 added the kind: cleanup Code removal, deprecation, refactorings, etc. label Aug 27, 2026
@yannl35133
yannl35133 requested review from a team as code owners August 27, 2026 14:44
@yannl35133 yannl35133 added the request: full CI Use this label when you want your next push to trigger a full CI. label Aug 27, 2026
@yannl35133
yannl35133 requested review from a team as code owners August 27, 2026 14:44
@coqbot-app coqbot-app Bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label Aug 27, 2026
@SkySkimmer

Copy link
Copy Markdown
Contributor

Isn't that a valid var name? I would be concerned about risk of capture if someone decides to use it in a mknamelambda or some such thing.

@SkySkimmer

Copy link
Copy Markdown
Contributor

IMO Prop is more likely to be inert than Var

@yannl35133

Copy link
Copy Markdown
Contributor Author

I took the names used for debugger printing in CClosure, the name can be changed.
Prop can fly under the radar much longer than Vars; would you rather have a Meta with negative index?

@ppedrot

ppedrot commented Aug 27, 2026

Copy link
Copy Markdown
Member

FWIW I don't like that change, because the "dumminess" may depend on the context. It's better to keep it local thus.

@yannl35133

yannl35133 commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

What are the level of dumminess we may want?

  • fail on kind that one is probably useless
  • fail on reduction
  • fail on typing

My issue with the current situation is that Prop fails nowhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind: cleanup Code removal, deprecation, refactorings, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants