Add a proper dummy constr, instead of using mkProp - #22410
Open
yannl35133 wants to merge 1 commit into
Open
Conversation
Contributor
|
Isn't that a valid var name? I would be concerned about risk of capture if someone decides to use it in a mknamelambda or some such thing. |
Contributor
|
IMO Prop is more likely to be inert than Var |
Contributor
Author
|
I took the names used for debugger printing in CClosure, the name can be changed. |
Member
|
FWIW I don't like that change, because the "dumminess" may depend on the context. It's better to keep it local thus. |
Contributor
Author
|
What are the level of dumminess we may want?
My issue with the current situation is that Prop fails nowhere. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was tired of seeing
mkPropused transparently as a dummy.I replaced all uses of it with
dummy, then went and checked whether these were dummies or actual uses of Prop.I am pretty sure for all uses, but this warrants a second opinion.
I'm also not too sure about
rocq/plugins/ssr/ssrfwd.ml
Line 351 in e47214b
which, if a dummy, hides it very deep, and
rocq/plugins/ssr/ssrequality.ml
Line 419 in e47214b
which may just need a substitution instead of an apparently useless let-in.