ENH: migrate wright to xsf - #199
Merged
Merged
Conversation
dschmitz89
reviewed
Jun 20, 2026
Comment on lines
+355
to
+356
| if (cond != NULL) { | ||
| *cond = z / (1.0 + *w); |
Contributor
There was a problem hiding this comment.
Is this condition number ever used anywhere?
Member
Author
There was a problem hiding this comment.
No it isn't. I wasn't sure what the procedure for migrating stuff is, i.e. I have made as few modifications as possible
Contributor
There was a problem hiding this comment.
Alright, let's leave it for a follow up then. First priority is to get this function into xsf in its current shape.
13 tasks
Co-authored-by: Daniel Schmitz <40656107+dschmitz89@users.noreply.github.com>
github-actions
Bot
added
the
needs-release-note-decision
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue
Towards #170
What does this implement/fix?
Migrates
wright.cto xsf.Additional information
AI Generation Disclosure
I used copilot to convert the tests from Python.